CardDB cleanup; index cards by CardRules#10617
Open
Jetz72 wants to merge 4 commits intoCard-Forge:masterfrom
Open
CardDB cleanup; index cards by CardRules#10617Jetz72 wants to merge 4 commits intoCard-Forge:masterfrom
Jetz72 wants to merge 4 commits intoCard-Forge:masterfrom
Conversation
…mes, adjust getRules lookup to prefer the former
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
allCardsByRules, an alternative toallCardsByNamethat guarantees that cards don't appear in multiple entries due to things like prepared cards nesting one card within the faces of another.allCardsByNameremains available for searching purposes.noAltversions of thegetAllCards/getUniqueCardsmethods when the name is not a parameter. The only real distinction between the two previously was that one version contained some unintended duplicate entries or was otherwise slightly wrong.rulesByNameintorulesByPrimaryNameandrulesByAltName. Allows anoAltvariant ofgetRules, though I chose to implement it as a parameter, which I might do for the others sometime too.uniqueCardsByNametouniqueCardsByRules, so that Emeritus of Ideation can no longer be chosen as the default printing of Ancestral Recall.getAllCards(CardRules)orgetAllCards(PaperCard)are preferable togetAllCards(card.getName()).