[ENG-11829] - Add revoke endpoint request for ORCID - #115
Conversation
There was a problem hiding this comment.
I understand and like the idea but I am not sure of the implementation. I tried to run this locally to see if token has been forwarded to OSF during ORCiD SSO. However, after a few attempts, CAS failed to start and crashed (without error messages) after the third line of the log.
2026-08-08 15:07:57,738 INFO [org.apereo.cas.configuration.DefaultCasConfigurationPropertiesSourceLocator] - <Configuration files found at [/etc/cas/config] are [[file [/etc/cas/config/cas.properties]]] under profile(s) [[standalone]]>
2026-08-08 15:07:58,234 INFO [org.apereo.cas.web.CasWebApplication] - <The following profiles are active: standalone>
2026-08-08 15:07:58,547 DEBUG [org.apereo.cas.web.CasWebApplicationContext] - <Refreshing org.apereo.cas.web.CasWebApplicationContext@584f5497>
# CRASHED
I reverted back the code to develop and it started up without a problem.
2026-08-08 15:14:13,949 INFO [org.apereo.cas.configuration.DefaultCasConfigurationPropertiesSourceLocator] - <Configuration files found at [/etc/cas/config] are [[file [/etc/cas/config/cas.properties]]] under profile(s) [[standalone]]>
2026-08-08 15:14:14,377 INFO [org.apereo.cas.web.CasWebApplication] - <The following profiles are active: standalone>
2026-08-08 15:14:14,694 DEBUG [org.apereo.cas.web.CasWebApplicationContext] - <Refreshing org.apereo.cas.web.CasWebApplicationContext@2d83c5a5>
2026-08-08 15:14:32,125 INFO [org.apereo.cas.configuration.CasConfigurationPropertiesValidator] - <Application context has validated CAS property sources and configuration successfully.
# CONTINUE TO START UP
First, I would suggest make sure you have a running CAS locally with develop (not just CAS starting up but also with successful sign-in / ORCiD login into OSF.
In case you use AI tool to help understand the code base and to assist the coding, please share the "thoughts" of AI (if available, e.g. Claude) so it will give me a good understanding of why / how it decides to implement the solution this way.
cslzchen
left a comment
cslzchen
left a comment
There was a problem hiding this comment.
Found the issue that breaks app start-up
| org.springframework.boot.autoconfigure.EnableAutoConfiguration=\ | ||
| io.cos.cas.oauth.config.OsfPostgresServiceRegistryConfiguration,\ | ||
| io.cos.cas.osf.config.JpaOsfDaoConfiguration,\ | ||
| io.cos.cas.osf.config.OrcidTokenJpaConfiguration,\ |
There was a problem hiding this comment.
Remove this one, which breaks start-up since io.cos.cas.osf.config.OrcidTokenJpaConfiguration does not exist.
| io.cos.cas.osf.config.OsfPostgresAuthenticationEventExecutionPlanConfiguration,\ | ||
| io.cos.cas.osf.config.OrcidTokenCaptureAuthenticationEventExecutionPlanConfiguration,\ | ||
| io.cos.cas.osf.web.config.OsfCasSupportActionsConfiguration,\ | ||
| io.cos.cas.osf.web.config.OrcidTokenRevocationWebConfiguration,\ |
There was a problem hiding this comment.
Similarly, this one breaks start-up because it doesn't exits.
cslzchen
left a comment
cslzchen
left a comment
There was a problem hiding this comment.
Locally tested and it doesn't work for me, neither the id nor the token are in the attribute map released to OSF from CAS
Screen.Recording.2026-08-08.at.12.46.21.mov
2 participants
Ticket
ENG-11829
Purpose
Changes
Dev Notes
QA Notes
Dev-Ops Notes