Skip to content

fix: increase page card overflow padding#23

Merged
Chefski merged 1 commit into
devfrom
codex/page-browser-card-overflow
Jul 19, 2026
Merged

fix: increase page card overflow padding#23
Chefski merged 1 commit into
devfrom
codex/page-browser-card-overflow

Conversation

@Chefski

@Chefski Chefski commented Jul 19, 2026

Copy link
Copy Markdown
Owner

Summary

  • increase vertical overflow padding around page browser rail cards
  • preserve the latest local UI adjustment before promoting dev to main

Validation

  • git diff --check
  • SwiftLint strict mode: 0 violations

Xcode builds and tests were not run locally, per repository instructions.

@Chefski
Chefski merged commit 6ba18bd into dev Jul 19, 2026
7 of 8 checks passed
@Chefski
Chefski deleted the codex/page-browser-card-overflow branch July 19, 2026 04:14
@greptile-apps

greptile-apps Bot commented Jul 19, 2026

Copy link
Copy Markdown

Greptile Summary

This PR bumps railCardVerticalOverflowPadding in PageBrowserMetrics from 12 to 24 points, doubling the vertical overflow padding around page browser rail cards before dev is promoted to main.

  • The change is confined to a single constant in the shared metrics enum; no view logic, data flow, or business logic is affected.
  • SwiftLint strict mode reports 0 violations, consistent with the project's pre-commit requirement in AGENTS.md.

Confidence Score: 5/5

Safe to merge — the change is a single numeric constant update with no logic, data, or API surface affected.

Doubling a padding constant in a dedicated metrics enum is low-risk. The value is used purely for visual layout, the rest of the enum is untouched, and SwiftLint reports zero violations.

No files require special attention.

Important Files Changed

Filename Overview
docmostly/Features/PageTree/PageBrowserMetrics.swift Single constant updated: railCardVerticalOverflowPadding 12 → 24; no logic changes, no style-guide violations.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["PageBrowserMetrics\nrailCardVerticalOverflowPadding = 24"] --> B["Rail card layout\n(SwiftUI view)"]
    B --> C["Vertical overflow space\nabove and below each card"]
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A["PageBrowserMetrics\nrailCardVerticalOverflowPadding = 24"] --> B["Rail card layout\n(SwiftUI view)"]
    B --> C["Vertical overflow space\nabove and below each card"]
Loading

Reviews (1): Last reviewed commit: "fix: increase page card overflow padding" | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant