Fix various provision failures: more cruft for Oceanbase and Firebolt - #1867
Merged
Conversation
Four independent fixes bundled:
- firebolt/start: also bind-mount /opt/clickbench/datasets_ro:ro
into the firebolt-core container. data/hits_*.parquet in cwd are
symlinks into that RO mount; without the bind, the symlinks
dangle inside the container. The INSERT INTO hits SELECT * FROM
hits_external then "succeeds" in <1 s inserting 0 rows, and every
query later returns count(*)=0.
- oceanbase/stop: wait for the observer to actually exit (up to
60 s poll + SIGKILL fallback) and rm the stale run/observer.pid
file. Without this the next ./start's observer.daemonize() reads
the still-live pid and refuses to start with
EDIAG [LIB] start_daemon: pid already exists
(exit code 96 → agent /provision fails). The install-time ./stop
hit this immediately on first provision.
- playground/images/build-base-rootfs.sh + agent unit:
Ubuntu 24.04's needrestart runs after every apt install/upgrade
and, in non-tty contexts, defaults to auto-restarting every
service whose libs got upgraded — INCLUDING the running
clickbench-agent.service (linked against libpython). Any install
that upgrades python3-dev or a shared runtime lib (arcticdb pip
install, rayforce build-essential, ...) drops the /provision
HTTP connection → the host sees ServerDisconnectedError and
gives up with an empty provision-log.
Set NEEDRESTART_MODE=l (list only) at two levels:
1. /etc/needrestart/conf.d/99-clickbench.conf in the base image
2. Environment= in the agent's systemd unit
Both take effect from the very first apt call; needrestart still
scans + reports, but never restarts anything.
…yforce oceanbase-row/stop was a byte-different sibling of oceanbase/stop — the fix I applied to oceanbase/stop earlier missed this one. Sync them (they should have been identical from the start). arcticdb and rayforce both OOM-killed at ~16 GB RSS during load — the guest kernel's dmesg shows: Out of memory: Killed process (python3|rayforce) anon-rss:1.6e7kB Same class as pandas/polars-dataframe. Add them to NEEDS_SWAP so they get the 256 GiB sparse swap.raw block device the agent mkswaps + swapons at boot.
alexey-milovidov
requested a deployment
to
benchmark-approval
September 6, 2026 12:03 — with 
GitHub Actions
Waiting
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.