Skip to content

test(e2e): raise app webServer startup timeout to 6 minutes - #3592

Merged
brandon-pereira merged 1 commit into
mainfrom
claude/e2e-app-startup-timeout
Nov 7, 2026
Merged

brandon-pereira merged 1 commit into
mainfrom
claude/e2e-app-startup-timeout

Conversation

@brandon-pereira

Copy link
Copy Markdown
Member

Summary

Since #3590, E2E on fork PRs runs on the 4-vCPU ubuntu-24.04 runner. On that runner, the Next.js production build in Playwright's app webServer can take longer than the 3-minute startup timeout, which fails the shard:

[WebServer]   Collecting build traces ...
Error: Timed out waiting 180000ms from config.webServer.

On #3582, shard 1 failed this way while shards 3 and 4 passed, so 3 minutes is borderline on that runner.

This raises the app startup timeout to 6 minutes. The timeout is only an upper bound, so the faster RUNNER_E2E runners aren't slowed down. The fork job timeout (25 minutes) still leaves room for the tests.

Test config only. No changeset needed.

How to reproduce

On main: rerun Main on fork PR #3582 or #3554. Some E2E shards fail with Timed out waiting 180000ms from config.webServer.

On this branch: after merge, rerun the same PRs. The build finishes inside the startup window.

@brandon-pereira
brandon-pereira requested a review from a team as a code owner November 6, 2026 23:02
@vercel

vercel Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
hyperdx-oss Ready Ready Preview Nov 6, 2026 11:07pm UTC
hyperdx-storybook Ready Ready Preview Nov 6, 2026 11:07pm UTC

Request Review

@github-actions github-actions Bot added the review/tier-2 Low risk — AI review + quick human skim label Nov 6, 2026
@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

🔵 Tier 2 — Low Risk

Small, isolated change with no API route or data model modifications.

Why this tier:

  • Standard feature/fix — introduces new logic or modifies core functionality

Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns.
SLA: Resolve within 4 business hours.

Stats
  • Production files changed: 1
  • Production lines changed: 3
  • Branch: claude/e2e-app-startup-timeout
  • Author: brandon-pereira

To override this classification, remove the review/tier-2 label and apply a different review/tier-* label. Manual overrides are preserved on subsequent pushes.

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

PR Review

✅ No issues found.

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Duplicate code analysis

No new duplicate code introduced by this PR.


jscpd compared this branch against origin/main
across app, api and common-utils. Only new clones are listed; the codebase
currently holds 110 in total (1.21%).
Run yarn dupes locally to reproduce, or yarn dupes:all for the full picture.

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Deep Review

✅ No critical issues found.

This is a test-config-only change: APP_SERVER_STARTUP_TIMEOUT_MS in packages/app/playwright.config.ts raised from 180 * 1000 (3 min) to 360 * 1000 (6 min), with the inline magnitude comment replaced by a rationale comment. The constant is the Playwright app webServer startup upper bound in both full-stack and local modes; raising it is monotonic and cannot slow faster runners, which proceed as soon as the port responds. The 6-minute window fits the 25-minute fork job budget (API 120s + app 360s = 8 min worst case, leaving ~17 min for tests), and the change is changeset-exempt per repo standards.


Reviewers (5): correctness, testing, maintainability, project-standards, kieran-typescript.

Testing gaps:

  • Raising the app webServer timeout to 360s delays fast-fail feedback on a genuinely hung build from 3 to 6 minutes, and a build time that gradually creeps toward the new ceiling will pass silently rather than failing fast — an acknowledged trade-off of the stated intent, with no automated guardrail tying the value to observed build times.

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

E2E Test Results

✅ All tests passed • 462 passed • 1 skipped • 1201s

Status Count
✅ Passed 462
❌ Failed 0
⚠️ Flaky 2
⏭️ Skipped 1

Tests ran across 4 shards in parallel.

View full report →

@brandon-pereira
brandon-pereira merged commit a1acac6 into main Nov 7, 2026
32 checks passed

This branch was successfully deployed

2 active deployments
Preview – hyperdx-oss — 7f178106 Deployed Nov 6, 2026 by vercel[bot]
Preview – hyperdx-storybook — 7f178106 Deployed Nov 6, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review/tier-2 Low risk — AI review + quick human skim

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants