Refactor restart state - #72
Merged
Merged
Conversation
Member
Author
|
PLAN_XACT_TROUBLE.md this evolved over the course of iterating on plans/future/xact_stash.md, which ultimately lead to concluding there were deep design flaws here. This PR starts with R4/R5 of PLAN_XACT_TROUBLE.md |
serprex
force-pushed
the
xact-stash
branch
2 times, most recently
from
July 21, 2026 15:18
41bce88 to
43cb377
Compare
harshil-goel
approved these changes
Jul 21, 2026
Replace cursor.bin with manifest.toml, benefits: * Restart no longer derives replay floor independently from pruning * TOAST retirement and future state pruning can use exactly same persisted position restart will use * Floor never moves past ClickHouse durability or locally fsynced WAL Status loop persists manifest.toml before publishing floor to pruners or sending source feedback Manifest includes IDENTIFY_SYSTEM info, refuses to progress on timeline switch, implementing better ergonomics which can be orchestrated with source is a future item XactBuffer no longer owns second emitter_ack_lsn, simplifies ack pipeline DrainedBatch consolidates cursor walking, simplifies TOAST, keeps WAL / backup more consistent with each other
harshil-goel
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace cursor.bin with manifest.toml, benefits:
Status loop persists manifest.toml before publishing floor to pruners or sending source feedback
Manifest includes IDENTIFY_SYSTEM info, refuses to progress on timeline switch,
implementing better ergonomics which can be orchestrated with source is a future item
XactBuffer no longer owns second emitter_ack_lsn, simplifies ack pipeline
DrainedBatch consolidates cursor walking, simplifies TOAST,
keeps WAL / backup more consistent with each other