Repository navigation
Fix ELBV2 capability detection for LocalStack's elasticloadbalancing health key - #16
Merged
Merged
Conversation
LocalStack's /_localstack/health reports ALB/NLB support under the key "elasticloadbalancing" (its real AWS service name), not "elbv2". mapServiceName only recognized elbv2/elb/elasticloadbalancingv2, so ELBV2 was never detected even when LocalStack reported it available -- every deploy needing an ALB (which is all of them, since ELBV2 is unconditionally required alongside ECS) was blocked by a false "missing capability" preflight violation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/_localstack/healthreports ALB/NLB support under the service keyelasticloadbalancing(the real AWS service name), butLocalStackCapabilityProbe.mapServiceNameonly recognizedelbv2/elb/elasticloadbalancingv2, so it never matched.ELBV2is unconditionally required alongsideECSinLocalStackDeployPreflight.requiredCapabilities, this made every LocalStack deploy fail preflight with a falseMISSING_CAPABILITYviolation, even when the running LocalStack instance actually supported it.elasticloadbalancingas a recognized key in the switch.Test plan
mapsElasticLoadBalancingHealthKeyToElbv2CapabilitytoLocalStackCapabilityProbeTest, asserting the health key maps to theELBV2capability.mvn -DskipTests=false test): all green, including the new test.