fix(views): unify Funkrufname fields to AutoCompleteBox - #145
Merged
Conversation
Roles (Funktionen add-row + transfer panel) and Scba (Atemschutz) had Funkrufname as a bare ComboBox with no PlaceholderText, rendering as a blank box with only a dropdown arrow. Meanwhile ETB, the operator's own call-sign field, and Forces' Funkrufname already use AutoCompleteBox, since a call sign might not be in Stammdaten yet (mutual aid, ad-hoc units) and the field must stay enterable. Convert the three remaining ComboBox instances to the same free-text-with-suggestions AutoCompleteBox pattern, with a "z. B. ..." placeholder like every other input field. NewCallSign/TransferCallSign were already plain string properties, so this is a XAML-only change. Closes #92 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EgFDVXVsJVKJAw1fxBETFR Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ComboBoxwith noPlaceholderText, rendering as a blank box with only a dropdown arrow — an outlier among the app's other call-sign-ish fieldsAutoCompleteBox(free-text with suggestions), since a call sign might not be in Stammdaten yet (mutual aid, ad-hoc units) — direction confirmed with the product owner over the open question in Unify call-sign input fields (AutoCompleteBox vs ComboBox split) into a reusable component #92ComboBoxinstances to the sameAutoCompleteBoxpattern, each with a "z. B. ..." placeholder like every other input fieldNewCallSign/TransferCallSignwere already plainstring?properties, so this is XAML-onlyCloses #92
Before / after
Funktionen (Roles)
Before:
After:
Atemschutz (Scba)
Before:
After:
Test plan
dotnet build src/LageBuch.App.Shared— cleandotnet test(Domain/AppLogic/Persistence/Documents/App/Sync/Sync.Hosting) — all passed, no assertions touch these controls (NewCallSign/TransferCallSign are plain strings)LageBuch.Acceptance.Tests(89 tests, run via the in-process xunit v3 runner —dotnet test's out-of-process launcher has a pre-existing, unrelated failure in this environment) — all passed, includingRolesTabRenderTestsandScbaTabRenderTestsRENDER_OUT+WorkspaceRenderHelper)🤖 Generated with Claude Code