-
-
Notifications
You must be signed in to change notification settings - Fork 49
London | 26-SDC-Mar | beko | Sprint 2 | implement an LRU cache in python #194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Abubakar-Meigag
wants to merge
2
commits into
CodeYourFuture:main
Choose a base branch
from
Abubakar-Meigag:beko-implement-LRU-cache-in-python
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| from typing import Optional | ||
|
|
||
| class _Node: | ||
|
|
||
| def __init__(self, key=None, value=None): | ||
| self.key = key | ||
| self.value = value | ||
| self.prev: Optional["_Node"] = None | ||
| self.next: Optional["_Node"] = None | ||
|
|
||
| class DoublyLinkedList: | ||
|
|
||
| def __init__(self): | ||
| self.head = _Node() | ||
| self.tail = _Node() | ||
| self.head.next = self.tail | ||
| self.tail.prev = self.head | ||
|
|
||
| def remove(self, node: _Node): | ||
| assert node.prev is not None | ||
| assert node.next is not None | ||
| node.prev.next = node.next | ||
| node.next.prev = node.prev | ||
|
|
||
| def add_to_front(self, node: _Node): | ||
| next_node = self.head.next | ||
| assert next_node is not None | ||
| node.next = next_node | ||
| node.prev = self.head | ||
| next_node.prev = node | ||
| self.head.next = node | ||
|
|
||
| def remove_last(self) -> _Node: | ||
| lru = self.tail.prev | ||
| assert lru is not None | ||
| self.remove(lru) | ||
| return lru | ||
|
|
||
|
|
||
| class LruCache: | ||
|
|
||
| def __init__(self, limit): | ||
| if limit <= 0: | ||
| raise ValueError("limit must be positive") | ||
|
|
||
| self.limit = limit | ||
| self.cache = {} | ||
| self.list = DoublyLinkedList() | ||
|
|
||
| def get(self, key): | ||
| if key not in self.cache: | ||
| return None | ||
|
|
||
| node = self.cache[key] | ||
| self.list.remove(node) | ||
| self.list.add_to_front(node) | ||
| return node.value | ||
|
|
||
| def set(self, key, value): | ||
| if key in self.cache: | ||
| node = self.cache[key] | ||
| node.value = value | ||
| self.list.remove(node) | ||
| self.list.add_to_front(node) | ||
| return | ||
|
|
||
| node = _Node(key, value) | ||
| self.cache[key] = node | ||
| self.list.add_to_front(node) | ||
|
|
||
| if len(self.cache) > self.limit: | ||
| lru = self.list.remove_last() | ||
| del self.cache[lru.key] | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not reuse your LinkedList class from the other exercise?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you're right i can reuse linked_list from the other exercise, I just chose to keep the linked list logic self-contained within the LRU cache because the node structure here is a bit different and a good exercise to have a different approach
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could store key-value pairs as a tuple in the node.