London | 26-SDC-Mar | beko | Sprint 2 | implement a linked list in py…#195
Open
Abubakar-Meigag wants to merge 1 commit into
Open
Conversation
Abubakar-Meigag
added
📅 Sprint 2
cjyuan
reviewed
Jun 30, 2026
Comment on lines
+4
to
+8
| class _Node: | ||
| def __init__(self, value): | ||
| self.value = value | ||
| self.next: Optional["_Node"] = None | ||
| self.prev: Optional["_Node"] = None |
There was a problem hiding this comment.
May I suggest exploring the use of __slots__ to reduce memory usage?
Comment on lines
+45
to
+62
| def remove(self, node): | ||
| if node == self.head: | ||
| self.head = node.next | ||
| if self.head: | ||
| self.head.prev = None | ||
| else: | ||
| self.tail = None | ||
|
|
||
| elif node == self.tail: | ||
| self.tail = node.prev | ||
| if self.tail: | ||
| self.tail.next = None | ||
| else: | ||
| self.head = None | ||
|
|
||
| else: | ||
| node.prev.next = node.next | ||
| node.next.prev = node.prev |
There was a problem hiding this comment.
Could you look up why, in a doubly linked List implementation, assigning .next and .previous of the removed node to None a good practice?
No change required.
Comment on lines
+35
to
+41
| if self.head == self.tail: | ||
| self.head = None | ||
| self.tail = None | ||
| else: | ||
| self.tail = self.tail.prev | ||
| if self.tail: | ||
| self.tail.next = None |
There was a problem hiding this comment.
Could also consider removing the tail by calling remove().
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…thon
Self checklist
Completed implementing a linked list in python