-
-
Notifications
You must be signed in to change notification settings - Fork 48
West Midlands | 26 March SDC | Iswat Bello | Sprint 2 | Improve code with caches #202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Iswanna
wants to merge
4
commits into
CodeYourFuture:main
Choose a base branch
from
Iswanna:improve-code-with-caches
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+85
−28
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
1c7938f
perf: optimize fibonacci function using manual memoisation
Iswanna 5d3c4ad
perf: implement manual memoisation for coin change algorithm
Iswanna 268059c
docs: document memoisation strategies for recursive optimizations
Iswanna 926abfd
Move CHANGES_MADE.md from making_changes directory to improve_with_ca…
Iswanna File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| # Changes Made: Optimization via Memoisation | ||
|
|
||
| ## Overview | ||
| The goal of these changes was to improve the performance of recursive functions that were previously performing redundant calculations. By introducing a manual cache (memoisation), the time complexity was reduced from exponential to linear. | ||
|
|
||
| ## 1. Fibonacci Optimization (`fibonacci.py`) | ||
| - **Implemented Memoisation**: Introduced a dictionary named `memo` to store the results of each Fibonacci term as it is calculated. | ||
| - **Improved Complexity**: | ||
| - **Before**: $O(2^n)$ (Exponential) - The function recalculated the same branches of the recursion tree millions of times. | ||
| - **After**: $O(n)$ (Linear) - Each term is calculated exactly once and then retrieved from the cache. | ||
| - **Readability**: Renamed the parameter `n` to `term_index` to more clearly describe that the function is looking for a specific position in a sequence. | ||
|
|
||
| ## 2. Making Change Optimization (`making_change.py`) | ||
| - **Recursive Helper Pattern**: Refactored the original iterative-recursive logic into a dedicated helper function (`ways_to_make_change_helper`) to better support memoisation. | ||
| - **State Tracking**: | ||
| - Created a **state key** using a Tuple: `(total, len(coins))`. | ||
| - **The "Why"**: A unique solution depends on both the amount of money left and which coins are still available. A tuple is used because it is immutable and can be used as a dictionary key. | ||
| - **Logic Refinement**: | ||
| - Updated the base case to return `1` when `total == 0`, representing a successful combination. | ||
| - Added `memo.clear()` in the wrapper function to ensure the cache is fresh for every new call to the main function. | ||
| - **Legacy Preservation**: Maintained original variable names (`coin`, `count_of_coin`, `intermediate`) while implementing the performance improvements. | ||
|
|
||
| ## 3. Technical Trade-offs: Space vs. Time | ||
| In both implementations, I applied the **Space-vs-Time trade-off**: | ||
| - **The Cost (Space)**: Increased memory usage to store the `memo` dictionary. | ||
| - **The Benefit (Time)**: Drastic reduction in execution time. For example, `ways_to_make_change(9176)` now returns a result instantly, whereas the unoptimised version would likely never finish on standard hardware. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,25 @@ | ||
| def fibonacci(n): | ||
| if n <= 1: | ||
| return n | ||
| return fibonacci(n - 1) + fibonacci(n - 2) | ||
| from typing import Dict | ||
|
|
||
| # 1. Create a dictionary to hold answers (the cache) | ||
| memo: Dict[int, int] = {} | ||
|
|
||
| def fibonacci(term_index: int) -> int: | ||
| """ | ||
| Calculate the term_indexth Fibonacci number using memoisation. | ||
|
|
||
| Time Complexity: O(n) - Each number up to n is calculated only once. | ||
| Space Complexity: O(n) - To store the recursion stack and the memo dictionary. | ||
| """ | ||
| # 2. The "Check": Do we already have the answer for term_index? | ||
| if term_index in memo: | ||
| return memo[term_index] | ||
|
|
||
| # 3. Base cases | ||
| if term_index <= 1: | ||
| return term_index | ||
|
|
||
| # 4. The "Store": Calculate and save the answer in the dictionary | ||
| memo[term_index] = fibonacci(term_index - 1) + fibonacci(term_index - 2) | ||
|
|
||
| # 5. Return the newly saved answer | ||
| return memo[term_index] |
58 changes: 34 additions & 24 deletions
58
Sprint-2/improve_with_caches/making_change/making_change.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,32 +1,42 @@ | ||
| from typing import List | ||
| from typing import List, Dict, Tuple | ||
|
|
||
| # 1. Create the cache | ||
| memo: Dict[Tuple[int, int], int] = {} | ||
|
|
||
| def ways_to_make_change(total: int) -> int: | ||
| """ | ||
| Given access to coins with the values 1, 2, 5, 10, 20, 50, 100, 200, returns a count of all of the ways to make the passed total value. | ||
|
|
||
| For instance, there are two ways to make a value of 3: with 3x 1 coins, or with 1x 1 coin and 1x 2 coin. | ||
| """ | ||
| return ways_to_make_change_helper(total, [200, 100, 50, 20, 10, 5, 2, 1]) | ||
| def ways_to_make_change_helper(total: int, coins: List[int]) -> int: | ||
| # Cache Key | ||
| state_key = (total, len(coins)) | ||
|
|
||
| # Cache Check | ||
| if state_key in memo: | ||
| return memo[state_key] | ||
|
|
||
| def ways_to_make_change_helper(total: int, coins: List[int]) -> int: | ||
| """ | ||
| Helper function for ways_to_make_change to avoid exposing the coins parameter to callers. | ||
| """ | ||
| if total == 0 or len(coins) == 0: | ||
| if total == 0: | ||
| return 1 | ||
| if total < 0 or len(coins) == 0: | ||
| return 0 | ||
|
|
||
| ways = 0 | ||
| for coin_index in range(len(coins)): | ||
| coin = coins[coin_index] | ||
| count_of_coin = 1 | ||
| while coin * count_of_coin <= total: | ||
| total_from_coins = coin * count_of_coin | ||
| if total_from_coins == total: | ||
| ways += 1 | ||
| else: | ||
| intermediate = ways_to_make_change_helper(total - total_from_coins, coins=coins[coin_index+1:]) | ||
| ways += intermediate | ||
| count_of_coin += 1 | ||
| # We take the first coin and pass the rest | ||
| coin = coins[0] | ||
| remaining_coins = coins[1:] | ||
|
|
||
| count_of_coin = 0 | ||
| while (coin * count_of_coin) <= total: | ||
| total_from_coins = total - (coin * count_of_coin) | ||
|
|
||
| intermediate = ways_to_make_change_helper(total_from_coins, remaining_coins) | ||
| ways += intermediate | ||
|
|
||
| count_of_coin += 1 | ||
|
|
||
| # Store Result | ||
| memo[state_key] = ways | ||
| return ways | ||
|
|
||
| def ways_to_make_change(total: int) -> int: | ||
| """Wrapper that matches the legacy test suite signature.""" | ||
| memo.clear() | ||
|
|
||
| default_coins = [200, 100, 50, 20, 10, 5, 2, 1] | ||
| return ways_to_make_change_helper(total, default_coins) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You spotted something sharp here: because
memolives at module level and lingers between calls, you had to addmemo.clear()so each freshways_to_make_change(...)doesn't reuse the previous call's cache. Nice catch — but needing to manually reset shared state is often a little hint worth listening to.What do you think would happen if the
memodictionary instead lived insideways_to_make_change— created fresh on each call — and the helper used that one (say, as a nested function, or by passing it down)? Would you still need to remember to.clear()it at all?Your current version is correct — this is purely about making it harder to get wrong later. Something to turn over when you're curious.