Skip to content

Cape Town | 25-ITP-May | Asanda Dunn | Sprint 1 | Form Controls #1283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
asandagwala wants to merge 3 commits into from
Closed

Cape Town | 25-ITP-May | Asanda Dunn | Sprint 1 | Form Controls #1283

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4d93253
complete form controls exercise
May 15, 2026
e0bdd60
form control
May 22, 2026
61422ad
updated form control
Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 41 additions & 5 deletions Form-Controls/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,51 @@ <h1>Product Pick</h1>
</header>
<main>
<form>
<!-- write your html here-->
<!--
try writing out the requirements first as comments
this will also help you fill in your PR message later-->
<div>
<label for = "name">Name</label>
<input type = "text" name = "name" id = "name" minlength = "2" required />

@kyle-tightest kyle-tightest Jun 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm currently able to submit with a name value of (two spaces). according to requirements i should not be able to do that

@kyle-tightest kyle-tightest Jun 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this was fixed thanks

</div>


<div>
<label for = "email">Email</label>
<input type = "email" name = "email" id = "email" required/>
</div>


<div>
<p>Colour</p>

@kyle-tightest kyle-tightest Jun 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm currently able to select multiple colours. according to requirements i should only be able to select 1 colour

@asandagwala asandagwala Jun 3, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good day Kyle,

Thank you for your review. I was able to see the mistake that I made and I have updated it. May you kindly review the chnages.

Thank you

@kyle-tightest kyle-tightest Jun 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this was fixed thanks

<input type ="radio" name = "colour" id = "red" value = "Red" required />
<label for = "red">Red</label>

<input type = "radio" name = "color" id = "blue" value = "Blue"/>
<label for = "blue">Blue</label>

<input type = "radio" name = "colour" id = "black" value = "Black"/>
<label for = "black">Black</label>
</div>

<div>
<label for="size">Size</label>

<select name="size" id="size" required>
<option value="">Select a size</option>
<option value="XS">XS</option>
<option value="S">S</option>
<option value="M">M</option>
<option value="L">L</option>
<option value="XL">XL</option>
<option value="XXL">XXL</option>
</select>
</div>
<div>
<button type="submit">Submit</button>
</div>
</form>
</main>
<footer>
<!-- change to your name-->
<p>By HOMEWORK SOLUTION</p>
<p>Asanda Dunn</p>
</footer>
</body>
</html>
Loading