London | 26-ITP-May | Damilola Odumosu| Sprint 1 | Form Controls #1347
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,27 +1,126 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="en" xmlns:> | ||
| <head> | ||
| <meta charset="utf-8"/> | ||
| <meta http-equiv="X-UA-Compatible" content="IE=edge"/> | ||
| <title>My form exercise</title> | ||
| <meta name="description" content="Product Pick form for selecting name, email, shirt color, and size."/> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1"/> | ||
| <link rel="stylesheet" href="main.css"> | ||
| <link rel="preconnect" href="https://fonts.googleapis.com"> | ||
| <link rel="preconnect" href="https://fonts.gstatic.com" crossorigin> | ||
| <link href="https://fonts.googleapis.com/css2?family=Lato:ital,wght@0,100;0,300;0,400;0,700;0,900;1,100;1,300;1,400;1,700;1,900&display=swap" | ||
| rel="stylesheet"> | ||
| <link href="https://fonts.googleapis.com/css2?family=Pinyon+Script&display=swap" rel="stylesheet"> | ||
| </head> | ||
| <body> | ||
| <header> | ||
| <h1>Product Pick</h1> | ||
| </header> | ||
| <main> | ||
|
|
||
|
|
||
| <form> | ||
| <!-- write your HTML here--> | ||
| <!-- | ||
| try writing out the requirements first as comments | ||
| this will also help you fill in your PR message later--> | ||
|
|
||
| <!-- first and lastname (ensure it contains at least two non-space characters.)--> | ||
| <!-- email (make sure the email is valid. Email addresses follow a consistent pattern.)--> | ||
| <!-- shirt color (I must provide 3 options. How will I ensure they do not choose other colors?)--> | ||
| <!-- shirt size (must provide the following 6 options: XS, S, M, L, XL, XXL)--> | ||
|
|
||
|
|
||
| <div class="form-group"> | ||
| <label for="firstname">First Name </label> | ||
| <input | ||
| type="text" | ||
| id="firstname" | ||
| name="firstname" | ||
| required | ||
| pattern="[\p{L}]+(?:['\-][\p{L}]+)*" | ||
|
There was a problem hiding this comment. The name should contain at least 2 characters. It also allows me to a single character at the Moment
Author
There was a problem hiding this comment. Thank you, i have fixed the pattern to require more than two characters |
||
| title="enter a valid name"> | ||
| </div> | ||
|
|
||
| <div class="form-group"> | ||
| <label for="lastname">Last Name</label> | ||
| <input | ||
| type="text" | ||
| id="lastname" | ||
| name="lastname" | ||
| required | ||
| pattern="[\p{L}]+(?:['\-][\p{L}]+)*" | ||
| title="enter a valid name"> | ||
| </div> | ||
|
|
||
| <div class="form-group"> | ||
| <label for="email">Email</label> | ||
| <input | ||
| type="email" | ||
| id="email" | ||
| name="email" | ||
| required> | ||
|
|
||
| </div> | ||
|
|
||
| <div class="form-group"> | ||
| <fieldset> | ||
| <legend>Choose a shirt color:</legend> | ||
| <div class="form-group-fieldset"> | ||
| <input | ||
| type="radio" | ||
| id="choice1" | ||
| name="shirt" | ||
| value="blue" | ||
| required> | ||
| <label for="choice1">Blue</label> | ||
| </div> | ||
|
|
||
| <div class="form-group-fieldset"> | ||
| <input | ||
| type="radio" | ||
| id="choice2" | ||
| name="shirt" | ||
| value="green" | ||
| > | ||
| <label for="choice2">Green</label> | ||
| </div> | ||
|
|
||
| <div class="form-group-fieldset"> | ||
| <input | ||
| type="radio" | ||
| id="choice3" | ||
| name="shirt" | ||
| value="yellow" | ||
| > | ||
| <label for="choice3">Yellow</label> | ||
| </div> | ||
| </fieldset> | ||
| </div> | ||
|
|
||
| <div class="form-group"> | ||
| <label for="sizing">Choose a size:</label> | ||
| <select id="sizing" name="size" required> | ||
| <option value="">--Please choose an option--</option> | ||
| <option value="ex-small">XS</option> | ||
| <option value="small">S</option> | ||
| <option value="medium">M</option> | ||
| <option value="large">L</option> | ||
| <option value="ex-large">XL</option> | ||
| <option value="ex-ex-large">XXL</option> | ||
|
|
||
| </select> | ||
| </div> | ||
| <button type="submit">Submit</button> | ||
| </form> | ||
| </main> | ||
|
|
||
| <footer> | ||
| <!-- change to your name--> | ||
| <p>By DAMILOLA ODUMOSU</p> | ||
| </footer> | ||
| </body> | ||
| </html> | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| * { | ||
| box-sizing: border-box; | ||
| margin:0; | ||
| } | ||
| header, footer{ | ||
| text-align:center; | ||
| } | ||
| h1{ | ||
| font-size: 4rem; | ||
| font-weight: 900; | ||
| line-height: 1; | ||
| } | ||
| body{ | ||
| font-family: "Lato", sans-serif; | ||
| font-size:18px; | ||
| background-color:#c1121f; | ||
| color:#fff; | ||
| line-height: 1.6; | ||
| } | ||
| form{ | ||
| width: 50%; | ||
| background: #780000; | ||
| padding:45px; | ||
| margin: 100px auto; | ||
| border: 2px solid #9a031e; | ||
| border-radius:5px | ||
| } | ||
| .form-group{ | ||
| margin-bottom:10px; | ||
| } | ||
| label { | ||
| text-transform: uppercase; | ||
| margin-right:10px; | ||
| } | ||
| input { | ||
| background: #fefae0; | ||
| color: #880d1e; | ||
| border: 2px solid #f26a8d; | ||
| border-radius: 10px; | ||
| padding: 0.5rem 1rem; | ||
| } | ||
|
|
||
| button{ | ||
| cursor: pointer; | ||
| background-color:#e63946; | ||
| padding: 1em 1.5em; | ||
| border: 0; | ||
| border-radius: 16px; | ||
| } | ||
| p{ | ||
| text-transform:lowercase; | ||
| font-family: "Pinyon Script", cursive; | ||
| font-weight: 400; | ||
| font-style: normal; | ||
| } | ||
|
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The w3 validator shows an error here
"Error: Attribute xmlns: not allowed here."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi luro, thank you, i have removed the 'xmlns' error and also the trailing slashes.