Skip to content

London | 26-ITP-May | Yonatan Teklemariam | Sprint 1 | Coursework#1360

Open
Yonatanteklemariam wants to merge 2 commits into
CodeYourFuture:mainfrom
Yonatanteklemariam:coursework/Sprint-1
Open

London | 26-ITP-May | Yonatan Teklemariam | Sprint 1 | Coursework#1360
Yonatanteklemariam wants to merge 2 commits into
CodeYourFuture:mainfrom
Yonatanteklemariam:coursework/Sprint-1

Conversation

@Yonatanteklemariam

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Used methods like substring, slice, padStart, and padEnd to format numbers correctly.

Converted pence values into a proper pounds‑and‑pence format.

Explored how indexing works in strings, including positive and negative indexes.

Tested browser functions such as alert and prompt to understand how they behave.

Learned what the console object is and how functions like console.log are accessed.

Questions

@Yonatanteklemariam Yonatanteklemariam added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 18, 2026

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work, good explanations. Only one question for you to take another look at

Comment thread Sprint-1/3-mandatory-interpret/2-time-format.js Outdated
@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 23, 2026
@Yonatanteklemariam Yonatanteklemariam added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jun 26, 2026
@Yonatanteklemariam

Yonatanteklemariam commented Jul 4, 2026

Copy link
Copy Markdown
Author

@LonMcGregor Hi Lon, it appears a few days have passed since I saw your last review, and I have also replied to your questions. Could you please find a moment to review my coursework, as the deadline to hand it in is approaching?Thanks

@LonMcGregor

Copy link
Copy Markdown

Hi @Yonatanteklemariam - I don't see any updates here. Did you remember to save, commit, and push your changes?

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 4, 2026
@Yonatanteklemariam Yonatanteklemariam added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jul 4, 2026
@Yonatanteklemariam

Copy link
Copy Markdown
Author

Hi @Yonatanteklemariam - I don't see any updates here. Did you remember to save, commit, and push your changes?

Hi @LonMcGregor, I've have now added improvements on the the code and added some clarifying comments,. Could you please review it?

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this. The task is complete now. Remember you can push commits as often as you want while working on a PR.

@LonMcGregor LonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants