CApe Town | May -ITP-26| Enice Mutanda|Sprint 1|Coursework#1386
Open
Enice-Codes wants to merge 6 commits into
Open
CApe Town | May -ITP-26| Enice Mutanda|Sprint 1|Coursework#1386Enice-Codes wants to merge 6 commits into
Enice-Codes wants to merge 6 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
Enice-Codes
added
📅 Sprint 1
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
Enice-Codes
force-pushed
the
coursework/sprint-1
branch
from
331a9b4 to
c8de3b5
Compare
Enice-Codes
force-pushed
the
coursework/sprint-1
branch
from
c8de3b5 to
49f8a23
Compare
Enice-Codes
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
Enice-Codes
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
Enice-Codes
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
Enice-Codes
added
Needs Review
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
Enice-Codes
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
Enice-Codes
added
the
Needs Review
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
Jun 29, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work on the stretch explore tasks.
I've left some comments for you to follow up with the interpreting tasks
| // Read the code and then answer the questions below | ||
|
|
||
| // a) How many function calls are there in this file? Write down all the lines where a function call is made | ||
| //one function call in line 4 ,5 |
There was a problem hiding this comment.
I think there are a few more function calls to find
| // e) What do you think the variable result represents? Can you think of a better name for this variable? | ||
|
|
||
| // the variable result represents the total length of the movie in hours and minutes. | ||
| //Better name is MOvieTime. |
There was a problem hiding this comment.
Does the name movieTime give a good idea of how this new variable is different to the original movieLenght?
Author
There was a problem hiding this comment.
I thought movieTime best described the function expression. However, it didn't seem different enough from the original variable name movieLength, so I renamed it movieLengthTime to make the distinction clearer.
| //Better name is MOvieTime. | ||
| // f) Try experimenting with different values of movieLength. Will this code work for all values of movieLength? Explain your answer | ||
| // Yes, this code will work for all values because it is using the modulus operator to calculate the remaining seconds and is using division to calculate the total hours. | ||
| // The code will correctly handle any length of movie in seconds and convert it to the appropriate format. |
There was a problem hiding this comment.
It may run without any errors, but does it always end up in the correct format? Are there any edge cases?
LonMcGregor
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
identified and correct errors
interpreted javascript
evaluated expressions
used Dev tools to answer the questions based on excercise