Glasgow | 25-ITP-May | Arthur Chan | Sprint 3 | practice-tdd - #1406
Closed
Motorcycle-lab wants to merge 5 commits into
Closed
Glasgow | 25-ITP-May | Arthur Chan | Sprint 3 | practice-tdd#1406Motorcycle-lab wants to merge 5 commits into
Motorcycle-lab wants to merge 5 commits into
Conversation
Motorcycle-lab
added
📅 Sprint 3
LonMcGregor
reviewed
Jul 1, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
This implementation doesn't quite look finished yet, but good start.
Your functions are working, but need to be formatted.
You are missing test cases. Have you comitted them yet?
| function countChar(stringOfCharacters, findCharacter) { | ||
| return 5 | ||
| let count=0; | ||
| for(let letter of stringOfCharacters) |
There was a problem hiding this comment.
Could you fix the formatting here? You IDE should be able to do that for you quite easily.
| function getOrdinalNumber(num) { | ||
| return "1st"; | ||
|
|
||
| if(num===11){ |
There was a problem hiding this comment.
What about larger numbers, like 111? What ordinal should you get?
LonMcGregor
added
the
Reviewed
Motorcycle-lab
added
Needs Review
LonMcGregor
reviewed
Jul 4, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work. Your implementations look complete now. Now you need to start uploading your test cases.
LonMcGregor
removed
the
Needs Review
added 3 commits
July 6, 2026 00:28
Motorcycle-lab
added
Needs Review
LonMcGregor
reviewed
Jul 6, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work, this task is completed now
LonMcGregor
added
Complete
Member
|
Closing PR because the May ITP run has finished. Feel free to re-open if you're still working on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
I finished the exercises inside sprint 3 . coursework 2 practice tdd
Questions
.