Skip to content

West-Midlands |26-May-ITP |Maryam Janjua |Sprint 1 |Complete Sprint 1 Course Work#1409

Open
maryam-devio wants to merge 6 commits into
CodeYourFuture:mainfrom
maryam-devio:coursework/sprint-1
Open

West-Midlands |26-May-ITP |Maryam Janjua |Sprint 1 |Complete Sprint 1 Course Work#1409
maryam-devio wants to merge 6 commits into
CodeYourFuture:mainfrom
maryam-devio:coursework/sprint-1

Conversation

@maryam-devio

@maryam-devio maryam-devio commented Jun 26, 2026

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • In this task we need to solve JavaScript tasks.
  • I deeply understand the concept read documentation, solve tasks and tested changes.
  • Theses exercises helped me to understand java-script syntax, built-in methods and data types briefly.

@maryam-devio maryam-devio added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 26, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 26, 2026
@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@maryam-devio maryam-devio added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 26, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 26, 2026
@maryam-devio maryam-devio added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed 📅 Sprint 2 Assigned during Sprint 2 of this module labels Jun 26, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 26, 2026
@github-actions

This comment has been minimized.

6 similar comments
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@maryam-devio maryam-devio added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Structuring-And-Testing-Data The name of the module. labels Jun 26, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 26, 2026
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

3 similar comments
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@maryam-devio maryam-devio added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 1 Assigned during Sprint 1 of this module labels Jun 26, 2026

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done doing the stretch tasks.

There's just one file I have comments about

*/
// e) What do you think the variable result represents? Can you think of a better name for this variable?

// The result represents the how long the movie is, in hours, minutes and seconds. It can named as MovieDuration.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does"MovieDuration" make enough of a distinction to the other variable name called "movieLength"?

// The result represents the how long the movie is, in hours, minutes and seconds. It can named as MovieDuration.
// f) Try experimenting with different values of movieLength. Will this code work for all values of movieLength? Explain your answer
// Yes, I changed the value of movieLength and it worked. The movieLength is the variable used in calculating other
// values and to evaluate the total length of movie. No newline at end of file

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may work without errors, but are there any possible inputs where the output doesn't look quite right?

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Module-Structuring-And-Testing-Data The name of the module. Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants