Skip to content

London | 26-May-ITP | Yonatan Teklemariam | Sprint 3 | Practice-tdd#1414

Open
Yonatanteklemariam wants to merge 8 commits into
CodeYourFuture:mainfrom
Yonatanteklemariam:coursework/sprint-3-practice-tdd
Open

London | 26-May-ITP | Yonatan Teklemariam | Sprint 3 | Practice-tdd#1414
Yonatanteklemariam wants to merge 8 commits into
CodeYourFuture:mainfrom
Yonatanteklemariam:coursework/sprint-3-practice-tdd

Conversation

@Yonatanteklemariam

@Yonatanteklemariam Yonatanteklemariam commented Jun 27, 2026 •
edited
Loading

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

written jest tests for all three functions and tested results as expected.

Questions

@github-actions

This comment has been minimized.

Sign in to view
@Yonatanteklemariam Yonatanteklemariam changed the title written jest tests for all the three functions and output tests as ex… London | 26-May-ITP | Yonatan Teklemariam | Sprint 3 | Practice-tdd Jun 27, 2026
@github-actions

This comment has been minimized.

Sign in to view
@Yonatanteklemariam Yonatanteklemariam added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 27, 2026
@Yonatanteklemariam

Yonatanteklemariam commented Jul 4, 2026

Copy link
Copy Markdown
Author

Hi @LonMcGregor, Could you please review this as well? Thanks

LonMcGregor
LonMcGregor reviewed Jul 4, 2026
View reviewed changes

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before I review this, did you remember to commit the implementation for count and get ordinal?

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 4, 2026
@Yonatanteklemariam

Yonatanteklemariam commented Jul 4, 2026

Copy link
Copy Markdown
Author

Before I review this, did you remember to commit the implementation for count and get ordinal?

I've now checked out every bit of the codes and re-run the tests and it works fine. Could you please review it now?

@Yonatanteklemariam Yonatanteklemariam added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jul 4, 2026
LonMcGregor
LonMcGregor reviewed Jul 4, 2026
View reviewed changes

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work here. The implementations all look good. Your tests are mostly good, but I think the final repeat task could be improved a little, see my comment

Comment thread Sprint-3/2-practice-tdd/repeat-str.test.js

@LonMcGregor LonMcGregor Jul 4, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have correctly tested the edge cases here (1, 0, error). Can you think of any other test cases that would make sense?

@Yonatanteklemariam Yonatanteklemariam Jul 4, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I've now added tests for null, "", non-string inputs and large repeat counts. Could you please now review it? Thanks for your patience

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 4, 2026
@Yonatanteklemariam Yonatanteklemariam added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jul 4, 2026
LonMcGregor
LonMcGregor reviewed Jul 4, 2026
View reviewed changes

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. This task is complete now

@LonMcGregor LonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 4, 2026
@Yonatanteklemariam

Yonatanteklemariam commented Jul 4, 2026

Copy link
Copy Markdown
Author

Good work. This task is complete now

Thank you for everything 🙏🏽

@Yonatanteklemariam Yonatanteklemariam mentioned this pull request Jul 5, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LonMcGregor LonMcGregor LonMcGregor left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Yonatanteklemariam @LonMcGregor