Cape Town | 25-ITP-May | Asanda Dunn | Sprint 2 | Coursework/sprint2

[asandagwala]

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Module: Structure and testing data Sprint 2 work

[cjyuan]

return a * b; would be enough.

The general syntax of the return statement is:

  return expression;

And the value of expression is returned.

[asandagwala]

Thank you, I have implemented the reommended changes

[cjyuan]

What type of value do you expect your function to return? A number or a string?
Does your function return the type of value you expect?

Different types of values may appear identical in the console output, but they are represented and treated differently in the program. For example,

  console.log(123);              // Output 123
  console.log("123");            // Output 123
  
  // Treated differently in the program
  let sum1 = 123 + 100;         // Evaluate to 223 -- a number
  let sum 2 = "123" + 100;      // Evaluate to "123100" -- a string.

---

Note:

return `${bmi.toFixed(1)}`;

is the same as

return bmi.toFixed(1);

[asandagwala]

I have corrected my mistake. Thank you so much

[cjyuan]

Could you also answer these questions?

What type of value do you expect your function to return? A number or a string?
Does your function return the type of value you expect?

[cjyuan]

Code is not properly formatted.

Have you installed the prettier VSCode extension and enabled "Format on save/paste" on VSCode,
as recommended in
https://github.com/CodeYourFuture/Module-Structuring-and-Testing-Data/blob/main/readme.md
?

[asandagwala]

I have used prettier for formatting, I am not sure why the formatting could be improper. I have attached a screenshot of what it looks like on my end. Please let me know how I can correct prettier or update the settings to make it work properly

[cjyuan]

It's good that you have installed prettier and know how to format code.

The code you showed in the screenshot is not the the file I was referring to.

[asandagwala]

My apologies, please see the correct code as referenced in your comment

[cjyuan]

This is how the code looks like on my VSCode.

If you haven't enabled format on save, you would need to manually use the "Format document" option to apply the formatter to format the code. And if you have more than one formatters installed, you may need to choose a default formatter for the "format on save" to work properly.

[cjyuan]

Why not complete the implementation of the formatAs12HourClock() function? It's a good programming exercise.

[asandagwala]

I did complete the formatAs12HourClock(), maybe I did not commit the work done on that file. Please check again if you are able to see it from your end

[cjyuan]

I don't see the implementation of this functio on GitHub. I also don't see the changes you said you made in Sprint-2/2-mandatory-debug/0.js.

You could click the "Files changed" tab on your PR on GitHub to see what files are changed on GitHub. That's also typically how the code reviewer views the changes in a PR.