West Midlands | ITP-26-May | Alina Sofragiu | Sprint 3 | Practice TDD#1420
Open
sofragiualina wants to merge 2 commits into
Open
West Midlands | ITP-26-May | Alina Sofragiu | Sprint 3 | Practice TDD#1420sofragiualina wants to merge 2 commits into
sofragiualina wants to merge 2 commits into
Conversation
sofragiualina
added
📅 Sprint 3
LonMcGregor
reviewed
Jul 4, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start, but I think you could expand your test cases a bit further
| @@ -22,3 +22,9 @@ test("should count multiple occurrences of a character", () => { | |||
| // And a character `char` that does not exist within `str`. | |||
| // When the function is called with these inputs, | |||
| // Then it should return 0, indicating that no occurrences of `char` were found. | |||
There was a problem hiding this comment.
Good test case for 0. Are there any other test cases you think you should add?
Author
There was a problem hiding this comment.
yes, I added more test cases for a single occurrence, an empty string, and case sensitivity
There was a problem hiding this comment.
These are good to test your edge cases. Do any of these test the normal operation of the repeat function?
Author
There was a problem hiding this comment.
yes, first test checks that the string is repeated multiple times count=3 and the second one checks the normal case count=1
LonMcGregor
added
Reviewed
sofragiualina
added
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Completed Test-Driven Development practice