London | 26-ITP-May | Gideon Defar | Sprint 1 | Coursework - #1553
London | 26-ITP-May | Gideon Defar | Sprint 1 | Coursework#1553gideondefar wants to merge 17 commits into
Conversation
|
I believe 0.js and 3.js in the mandatory errors section also require a solution. I also noticed that not all of the files run without errors. As a general practice, it’s worth running each file before pushing your changes to make sure there are no syntax or runtime errors. |
|
Note: It seems this PR has been reviewed. So I changed to label to |
|
|
Good job! Most of the issues have been resolved, only few tiny ones left. |
Could you please tell me a specific bug, so I can fix it. I couldn't see unresolved issue; I guess I have fixed all your feedback. |
|
@gideondefar I think these two unresolved comments have not yet been addressed: |
@cjyuan I have carefully go through them and resolved the issue thank you very much. |
|
@gideondefar The commented-out code was not removed in your latest commit. |
@cjyuan I don't know why it still display on his comment but it's gone on the file, I have double checked by fetching to my machine and push to the origin branch and from here when I click on edit file it doesn't exist. thanks!
|
| // console.log(`I was born in ${cityOfBirth}`); | ||
| // const cityOfBirth = "Bolton"; |
There was a problem hiding this comment.
I was referring to these two lines of commented out code.
There was a problem hiding this comment.
It's an easy fix. I will mark this PR as "Complete" first.

Self checklist
Changelist
In this PR, I have completed the required Sprint 1 coursework exercises.
Questions
How do you recommend formatting long multi-line explanations or breakdowns for formulas in the code? Is a detailed block comment preferred over individual single-line comments according to the style guide?