Skip to content

London | 26-ITP-Sep| Mars Adesina | Sprint 1 | formatAs12HourClock #1640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marscancode wants to merge 6 commits into
base: main
Choose a base branch
from
Open

London | 26-ITP-Sep| Mars Adesina | Sprint 1 | formatAs12HourClock #1640

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dbad16a
added edge case tests for time converter function
marscancode Oct 3, 2026
a21732b
updated function to include midnight and half hour time conversion
marscancode Oct 3, 2026
bd95d82
added edge case test for 12pm conversion
marscancode Oct 5, 2026
be8c392
added edge case test for 1 minute before 12pm
marscancode Oct 5, 2026
2c38ec5
added edge case test for 1 minute before midnight
marscancode Oct 5, 2026
6eace5f
renamed edge case test 30 mins before midnight
marscancode Oct 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions format-clock-edge-cases/timeConverter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,16 @@
function formatAs12HourClock(time) {

const hours = Number(time.slice(0, 2));
const minutes = time.slice(3, 5);

if (hours > 12) {
return `${hours - 12}:00 pm`;
if (hours === 0) {
return `12:${minutes} am`;
} else if (hours > 12) {
return `${hours - 12}:${minutes} pm`;
} else if (hours === 12) {
Comment thread
marscancode marked this conversation as resolved.
return `12:${minutes} pm`;
} else {
return `${time} am`;
}
return `${time} am`;
}

export {formatAs12HourClock};
export { formatAs12HourClock };
54 changes: 49 additions & 5 deletions format-clock-edge-cases/timeConverter.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,55 @@
import {formatAs12HourClock} from "./timeConverter.js";
import { formatAs12HourClock } from "./timeConverter.js";
import assert from "node:assert";
import test from "node:test";

test("correctly convert time after 12:00", function(){
assert.equal(formatAs12HourClock("23:00"), "11:00 pm");
test("correctly convert time after 12:00", function () {
assert.equal(formatAs12HourClock("23:00"), "11:00 pm");
});

test("can correctly convert morning time", function() {
assert.equal(formatAs12HourClock("08:00"), "08:00 am");
test("can correctly convert morning time", function () {
assert.equal(formatAs12HourClock("08:00"), "08:00 am");
});

test("can correctly convert midnight", function () {
assert.equal(formatAs12HourClock("00:00"), "12:00 am");
});

test("correctly convert time 1 hour before 12:00", function () {
Comment thread
marscancode marked this conversation as resolved.
assert.equal(formatAs12HourClock("11:00"), "11:00 am");
});

test("correctly convert time 2 hours before 12:00", function () {
assert.equal(formatAs12HourClock("10:00"), "10:00 am");
});

test("correctly convert time 3 hours before 12:00", function () {
assert.equal(formatAs12HourClock("09:00"), "09:00 am");
});

test("can correctly convert every half hour before 12:00", function () {
assert.equal(formatAs12HourClock("09:30"), "09:30 am");
});

test("can correctly convert hours in the afternoon", function () {
assert.equal(formatAs12HourClock("13:00"), "1:00 pm");

@abdishakoor-dev abdishakoor-dev Oct 5, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional, not needed for Complete: morning times keep their zero ("08:00 am"), but afternoon times drop it ("1:00 pm"). Which style do you think the function should use? Whichever you pick, it's worth being the same for both.

});

test("correctly convert half hour after 12:00", function () {
assert.equal(formatAs12HourClock("13:30"), "1:30 pm");
});

test("correctly convert half hour before midnight", function () {
assert.equal(formatAs12HourClock("23:30"), "11:30 pm");
});

test("correctly convert 12:00 pm", function () {
assert.equal(formatAs12HourClock("12:00"), "12:00 pm");
});

test("correctly convert 1 minute before 12:00pm", function () {
assert.equal(formatAs12HourClock("11:59"), "11:59 am");
});

test("correctly convert 1 minute before midnight", function () {
assert.equal(formatAs12HourClock("23:59"), "11:59 pm");
});
Loading