Skip to content

Manchester | 26-ITP-Sep | Salah Alsabhi | Sprint 1 | format clock edge cases #1642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
salahalsabhi wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Manchester | 26-ITP-Sep | Salah Alsabhi | Sprint 1 | format clock edge cases #1642

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f016ea8
Fix formatAs12HourClock edge cases and add tests
salahalsabhi Oct 4, 2026
1b5fe5e
Simplify displayHour and use slice(-2) for minutes
salahalsabhi Oct 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions format-clock-edge-cases/timeConverter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,14 @@
function formatAs12HourClock(time) {
// function receives a string representing time in 24-hour format as an argument

function formatAs12HourClock(time) {
const hours = Number(time.slice(0, 2));
const minutes = time.slice(-2);

const period = hours >= 12 ? "pm" : "am";

const displayHour = hours % 12 || 12;

if (hours > 12) {
return `${hours - 12}:00 pm`;
}
return `${time} am`;
return `${displayHour}:${minutes} ${period}`;
}

export {formatAs12HourClock};
export { formatAs12HourClock };
33 changes: 26 additions & 7 deletions format-clock-edge-cases/timeConverter.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,30 @@
import {formatAs12HourClock} from "./timeConverter.js";
import { formatAs12HourClock } from "./timeConverter.js";
import assert from "node:assert";
import test from "node:test";

test("correctly convert time after 12:00", function(){
assert.equal(formatAs12HourClock("23:00"), "11:00 pm");
});
test("correctly convert time after 12:00", () =>
assert.equal(formatAs12HourClock("23:00"), "11:00 pm"));

test("can correctly convert morning time", function() {
assert.equal(formatAs12HourClock("08:00"), "08:00 am");
});
test("can correctly convert morning time", () =>
assert.equal(formatAs12HourClock("08:00"), "8:00 am"));

test("can correctly convert midnight", () =>
assert.equal(formatAs12HourClock("00:00"), "12:00 am"));

test("noon is pm", () =>
assert.equal(formatAs12HourClock("12:00"), "12:00 pm"));

test("noon with minutes", () =>
assert.equal(formatAs12HourClock("12:45"), "12:45 pm"));

test("afternoon keeps minutes", () =>
assert.equal(formatAs12HourClock("13:30"), "1:30 pm"));

test("evening keeps minutes", () =>
assert.equal(formatAs12HourClock("23:15"), "11:15 pm"));

test("midnight with minutes", () =>
assert.equal(formatAs12HourClock("00:30"), "12:30 am"));

test("just before noon", () =>
assert.equal(formatAs12HourClock("11:59"), "11:59 am"));
Loading