Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion practice-tdd/count.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
export function countChar(stringOfCharacters, findCharacter) {
return 5
let count = 0;
for (let i = 0; i < stringOfCharacters.length; i++) {
if (stringOfCharacters[i] === findCharacter) {
count = count + 1;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an alternative syntax we can use in JS to increment numbers by one?

}
}
return count;
}
//1st test passsed

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean up comments before committing work up

5 changes: 5 additions & 0 deletions practice-tdd/count.test.js

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a smaller first test you could write for this? Have a think of what the simplest starting input could be

Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,8 @@ test("should count multiple occurrences of a character", () => {
// And a character `char` that does not exist within `str`.
// When the function is called with these inputs,
// Then it should return 0, indicating that no occurrences of `char` were found.
test("A character that does not exist in the string should return 0.", () => {
const str = "aaaaa";
const char = "p";
expect(countChar(str, char)).toEqual(0);
});
19 changes: 18 additions & 1 deletion practice-tdd/get-ordinal-number.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,20 @@
export function getOrdinalNumber(num) {
return "1st";
const exceptions = [11, 12, 13];
let strNum = num.toString();

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could strNum be aconst variable? Would this break the code?


for (let exception of exceptions) {
if (strNum.endsWith(exception)) {
return strNum + "th";
}
}

if (strNum.endsWith("1")) {
return strNum + "st";
} else if (strNum.endsWith("2")) {
return strNum + "nd";
} else if (strNum.endsWith("3")) {
return strNum + "rd";
} else {
return strNum + "th";
}
Comment on lines +11 to +19

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slight refactor possible here: if we are returning a value from each if statement do we need the else if or is a if statement enough?

Here I'm thinking about cleaning up the code to do the bare minimum, avoiding overengineering when it doesn't actually change the behaviour in the code.

}
31 changes: 31 additions & 0 deletions practice-tdd/get-ordinal-number.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,37 @@ import { getOrdinalNumber } from "./get-ordinal-number.js";
// Then the function should return a string by appending "st" to the number.
test("should append 'st' for numbers ending with 1, except those ending with 11", () => {
expect(getOrdinalNumber(1)).toEqual("1st");
expect(getOrdinalNumber(11)).toEqual("11th");
expect(getOrdinalNumber(111)).toEqual("111th");
expect(getOrdinalNumber(21)).toEqual("21st");
expect(getOrdinalNumber(131)).toEqual("131st");
});
// Case 2: Numbers ending with 2 (but not 12)
// When the number ends with 2, except those ending with 12,
// Then the function should return a string by appending "nd" to the number.
test("should append 'nd' for numbers ending with 2, except those ending with 12", () => {
expect(getOrdinalNumber(2)).toEqual("2nd");
expect(getOrdinalNumber(12)).toEqual("12th");
expect(getOrdinalNumber(112)).toEqual("112th");
expect(getOrdinalNumber(22)).toEqual("22nd");
expect(getOrdinalNumber(132)).toEqual("132nd");
});
// Case 3: Numbers ending with 3 (but not 13)
// When the number ends with 3, except those ending with 13,
// Then the function should return a string by appending "rd" to the number.
test("should append 'rd' for numbers ending with 3, except those ending with 13", () => {
expect(getOrdinalNumber(3)).toEqual("3rd");
expect(getOrdinalNumber(33)).toEqual("33rd");
expect(getOrdinalNumber(13)).toEqual("13th");
expect(getOrdinalNumber(113)).toEqual("113th");
expect(getOrdinalNumber(133)).toEqual("133rd");
});
// Case 4: Numbers ending within the range of 4-9 (also ending with 0)
// When the number ends within the range of 4-9 or ends with 0.
// Then the function should return a string by appending "th" to the number.
test("should append 'th' for numbers ending within 4-9, or ends with 0", () => {
expect(getOrdinalNumber(5)).toEqual("5th");
expect(getOrdinalNumber(37)).toEqual("37th");
expect(getOrdinalNumber(139)).toEqual("139th");
expect(getOrdinalNumber(100)).toEqual("100th");
});
6 changes: 2 additions & 4 deletions practice-tdd/repeat-str.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
export function repeatStr() {
// Your implementation of this function must *not* call String.prototype.repeat (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/repeat).
// The goal is to re-implement that function, not to use it.
return "hellohellohello";
export function repeatStr(str, count) {
return str.repeat(count);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function was specifically NOT meant to call the repeat method but you have done so here. Please re-design this function to not use the repeat method, design logic yourself.

}
15 changes: 15 additions & 0 deletions practice-tdd/repeat-str.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,28 @@ test("should repeat the string count times", () => {
// Given a target string `str` and a `count` equal to 1,
// When the repeatStr function is called with these inputs,
// Then it should return the original `str` without repetition.
test("should return original str value if called once", () => {
const str = "hello";
const count = 1;
expect(repeatStr(str, count)).toEqual(str);
});

// Case: Handle count of 0:
// Given a target string `str` and a `count` equal to 0,
// When the repeatStr function is called with these inputs,
// Then it should return an empty string.
test("should return empty string if called with count =0", () => {
const str = "hello";
const count = 0;
expect(repeatStr(str, count)).toEqual("");
});

// Case: Handle negative count:
// Given a target string `str` and a negative integer `count`,
// When the repeatStr function is called with these inputs,
// Then it should throw an error, as negative counts are not valid.
test("should throw error as negatives are not valid", () => {
const str = "hello";
const count = -1;
expect(() => repeatStr(str, count)).toThrow(Error);
});
Loading