Skip to content

Manchester | 26-ITP-Sept | Aklilu Tsehaye | Sprint 1 | Format clock edge cases #1656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AkliluMihtsun wants to merge 2 commits into
base: main
Choose a base branch
from
+29 −10
Open

Manchester | 26-ITP-Sept | Aklilu Tsehaye | Sprint 1 | Format clock edge cases #1656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18ec108
added edge cases
AkliluMihtsun Oct 6, 2026
6a11e56
checked all the edge cases
AkliluMihtsun Oct 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions format-clock-edge-cases/timeConverter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,18 @@
function formatAs12HourClock(time) {

const hours = Number(time.slice(0, 2));
const slicedMinutes = time.slice(-2);

if (hours > 12) {
return `${hours - 12}:00 pm`;
if (hours === 0) {
return `12:${slicedMinutes} am`;
} else if (hours > 1 && hours <= 11) {
return `0${hours}:${slicedMinutes} am`;
} else if (hours === 12) {
return `12:${slicedMinutes} pm`;
} else if (hours > 12 && hours <= 21) {
return `0${hours - 12}:${slicedMinutes} pm`;
} else if (hours === 22 || hours === 23) {
return `${hours - 12}:${slicedMinutes} pm`;
}
return `${time} am`;
}

export {formatAs12HourClock};
export { formatAs12HourClock };
22 changes: 17 additions & 5 deletions format-clock-edge-cases/timeConverter.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,23 @@
import {formatAs12HourClock} from "./timeConverter.js";
import { formatAs12HourClock } from "./timeConverter.js";
import assert from "node:assert";
import test from "node:test";

test("correctly convert time after 12:00", function(){
assert.equal(formatAs12HourClock("23:00"), "11:00 pm");
test("correctly convert time after 12:00", function () {
assert.equal(formatAs12HourClock("14:00"), "02:00 pm");
});

test("can correctly convert morning time", function() {
assert.equal(formatAs12HourClock("08:00"), "08:00 am");
test("can correctly convert morning time", function () {
assert.equal(formatAs12HourClock("08:00"), "08:00 am");
});

test("can correctly convert midnight time", function () {
assert.equal(formatAs12HourClock("00:00"), "12:00 am");
});

test("can correctly convert midday time", function () {
assert.equal(formatAs12HourClock("12:00"), "12:00 pm");
});

test("can correctly convert 22:00 and 23:00 time", function () {
assert.equal(formatAs12HourClock("22:00"), "10:00 pm");
});
Loading