Sheffield | 25-SDC-Nov | Hassan Osman | Sprint 5 | Prep Exercises by HassanOHOsman · Pull Request #293 · CodeYourFuture/Module-Tools

HassanOHOsman · 2025-12-08T16:52:19Z

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

This PR contains my solutions to all the "Prep Exercises" in Sprint 5 of the "Tools" module.

…en running mypy

…ring

…unction calls

…argument in open_account

LonMcGregor · 2026-01-14T11:57:04Z

There are a lot of files comitted here, can you take a look and figure out why that is happening?

HassanOHOsman · 2026-01-14T23:08:14Z

There are a lot of files comitted here, can you take a look and figure out why that is happening?

Yes, I just ignored the .venv so that it's easy for you to navigate through. Please let me know if you need anything else :)

LonMcGregor

Good work on these tasks, there are just two of them I have suggestions for improvements in

LonMcGregor · 2026-01-19T11:03:33Z

+def print_family_tree(person: Person) -> None:
+    print(person.name)
+    for child in person.children:
+        print(f"- {child.name} ({child.age})")


This correctly prints out this person's children. Do you think there is a way to make it print out the whole family tree?

(hint: recursion)

Hi!
The current code actually does print the whole family tree (the parent: Imran and the 2 children Fatima & Aisha as per my examples). I've attached a screenshot. Nevertheless, if you still think it's better to be done through the recursion approach please let me know. Thank you! :)

Great work on this task so far. I was thinking about if, for example in that screenshot, if Aisha had a child as well (i.e. Imran's grandchild). Could you design the function in such a way that it could print that out as well? Recursion might help here.

I now understand. Thank you for clarifying. Done as instructed. Please review and let me know if there's anything else that needs improving. I appreciate you help :)

… up with "None" for the selected/entered OS option by end-user

…desentant objects

LonMcGregor

Very good work on this task! Good idea to add some extra indentation to improve the output. you are complete with this sprint now

illicitonion · 2026-06-30T17:37:33Z

Closing PR because the SDC run has finished. Feel free to re-open if you're still working on it.

HassanOHOsman added 30 commits December 2, 2025 18:38

create a dir for my exercises and a .py file for exercise 1

d7860a4

provide 2 solutions to exercise 1

c6edd33

rename file

bbca608

create file to exercise 1

597f47e

add exercise 1 question

adec5ea

answer to Q 1 of exercises

c202adf

create venv

4917fe7

install mypy

ab0e5d5

create a test file to test some py code

b0143fd

adding type annotation to the function def to avoid getting errors wh…

5c7d52c

…en running mypy

re-add type annotation to function def

6803aed

delete the test file

dd86ef8

create a .py file for exercise 3

9df4222

type annotate open_account function return

bf4f92c

type anno. open_account arguments

0b58dee

add a return line to function open-account

e133ed6

type anno. return for function sum_balance

0692d80

type anno. the argument accounts of function sum_balances

93e8215

type annotate the argument and return for function format_pence_as_st…

eaa2fa4

…ring

adding the missing third argument: "balances" to the 2 open_account f…

b7f3ae2

…unction calls

updated all the int values to float

530b650

updating type anno. and making a few changes

b55e70c

correcting syntax error in sum_balances func and the name of the 1st …

ccce3db

…argument in open_account

fixed bugs in the 2 open_account fuc calls at the bottom

bb87b72

corrected the name bug for the format_pence_as_string call at the bottom

ce70769

create .py file for exercise 4

a70ac33

add solution to problem 4

550f320

create .py file for exercise 5

ee4aae2

add a question to problem 5

dc9fa85

create a new function as per exercise 5 requirments

23cf5c5

HassanOHOsman added 2 commits December 8, 2025 16:43

add prediction

ff5238e

comment problematic lines

40d209b

HassanOHOsman added 📅 Sprint 5 Assigned during Week 5 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Dec 8, 2025

LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jan 14, 2026

HassanOHOsman added 2 commits January 14, 2026 23:03

create a .gitignore file to ignore .venv dir due to its so many files

793653a

ignoring all .venv files

be69676

HassanOHOsman added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jan 14, 2026

LonMcGregor reviewed Jan 19, 2026

View reviewed changes

LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jan 19, 2026

HassanOHOsman added 2 commits January 21, 2026 23:50

Making avaiable OS options available to end-user for better UX experince

eec6b69

call the function in the last line and remove "print" to avoid ending…

750d9b2

… up with "None" for the selected/entered OS option by end-user

HassanOHOsman added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jan 21, 2026

LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jan 26, 2026

HassanOHOsman added 2 commits January 26, 2026 13:40

make the func print_family_tree print recursively

ea186be

improve the readability of the duct output by adding indentation for …

ecd74be

…desentant objects

HassanOHOsman added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jan 26, 2026

LonMcGregor reviewed Jan 27, 2026

View reviewed changes

LonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jan 27, 2026

illicitonion closed this Jun 30, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Sheffield | 25-SDC-Nov | Hassan Osman | Sprint 5 | Prep Exercises #293

Sheffield | 25-SDC-Nov | Hassan Osman | Sprint 5 | Prep Exercises #293
HassanOHOsman wants to merge 97 commits into
CodeYourFuture:mainfrom
HassanOHOsman:answers/prep-exercises

HassanOHOsman commented Dec 8, 2025

Uh oh!

LonMcGregor commented Jan 14, 2026

Uh oh!

HassanOHOsman commented Jan 14, 2026

Uh oh!

LonMcGregor left a comment

Uh oh!

LonMcGregor Jan 19, 2026

Uh oh!

HassanOHOsman Jan 21, 2026 •

edited

Loading

Uh oh!

LonMcGregor Jan 26, 2026

Uh oh!

HassanOHOsman Jan 26, 2026

Uh oh!

Uh oh!

LonMcGregor left a comment

Uh oh!

illicitonion commented Jun 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

HassanOHOsman commented Dec 8, 2025

Uh oh!

LonMcGregor commented Jan 14, 2026

Uh oh!

HassanOHOsman commented Jan 14, 2026

Uh oh!

LonMcGregor left a comment

Choose a reason for hiding this comment

Uh oh!

LonMcGregor Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

HassanOHOsman Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LonMcGregor Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

HassanOHOsman Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

LonMcGregor left a comment

Choose a reason for hiding this comment

Uh oh!

illicitonion commented Jun 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

HassanOHOsman Jan 21, 2026 •

edited

Loading