London | 26-SDC-Mar | Jamal Laqdiem | Sprint 2 | shell pipelines exercises#367
London | 26-SDC-Mar | Jamal Laqdiem | Sprint 2 | shell pipelines exercises#367jamallaqdiem wants to merge 4 commits into
Conversation
Fix expected output in sed exercise instructions (CodeYourFuture#353)
jamallaqdiem
added
Needs Review
SlideGauge
left a comment
SlideGauge
left a comment
There was a problem hiding this comment.
Could you adjust the settings of your editor? All the files are missing the trailing end of line.
|
|
||
| # TODO: Write a command to output the names of the files in the sample-files directory whose name starts with an upper case letter and doesn't contain any other upper case letters. | ||
| # Your output should contain 7 files. | ||
| ls -1 sample-files | grep '^[A-Z][a-z]*$' No newline at end of file |
There was a problem hiding this comment.
The regex '^[A-Z][a-z]*$' captures "starts with uppercase, then only lowercase letters." But the task says "doesn't contain any other upper case letters" — it says nothing about restricting digits, dots, hyphens, etc. A filename like Foo.txt or File1 would NOT match your regex even though it satisfies the task requirement.
| # Your output should be the number 7. | ||
| #!/bin/bash | ||
|
|
||
| ls -1 sample-files | grep '^[A-Z][a-z]*$' | wc -l No newline at end of file |
There was a problem hiding this comment.
Thnaks for reviewing, I addressed the issues.
SlideGauge
added
Reviewed
|
Good job, could you do a couple of fixes I pointed out? |
|
I changed the setting to add a trainling end line at save. |
jamallaqdiem
added
the
Needs Review
SlideGauge
added
Complete
|
Nice, review completed |
|
Closing PR because the SDC run has finished. Feel free to re-open if you're still working on it. |
3 participants
Self checklist
Changelist
Completed the exercises shell pipelines.