West Midlands | 26 March SDC | Iswat Bello | Sprint 2 | jq exercises#410
Closed
Iswanna wants to merge 5 commits into
Closed
West Midlands | 26 March SDC | Iswat Bello | Sprint 2 | jq exercises#410Iswanna wants to merge 5 commits into
Iswanna wants to merge 5 commits into
Conversation
- script-01.sh: Output the person's name without quotes. - script-02.sh: Output the person's address as a single comma-separated line without quotes.
- script-03.sh: Output the person's name and profession in the required format. - script-04.sh: Output each player's name on a separate line as required.
…es.json - script-05.sh: Output each player's name and city on one line. - script-06.sh: Output each player's name and their first score. - script-07.sh: Output each player's name and their last score.
- script-08.sh: Output each player's name and number of games played. - script-09.sh: Output each player's name and total score. - script-10.sh: Output the sum of all players' first scores. - script-11.sh: Output the sum of all scores from all games and players.
Iswanna
added
📅 Sprint 2
nedssoft
added
Review in progress
nedssoft
approved these changes
Apr 11, 2026
nedssoft
left a comment
nedssoft
left a comment
There was a problem hiding this comment.
Good job in completing the exercises. The comment I left are good to haves as the requirements are already met.
Comment on lines
+8
to
+9
|
|
||
| jq -r '.[] | "\(.name) \(.city)"' ./scores.json No newline at end of file |
There was a problem hiding this comment.
Can you think of another way to achieve the same without the slashes and brackets to improve readability?
Author
There was a problem hiding this comment.
Yes, one simpler option is jq -r '.[] | .name + " " + .city' ./scores.json
Comment on lines
+10
to
+14
| jq -r '.[] | "\(.name) \(.scores[0])"' scores.json | ||
|
|
||
|
|
||
|
|
||
|
|
Author
There was a problem hiding this comment.
Yes, one simpler option is jq -r .[] | .name + " " + (.scores[0] | tostring)' scores.json
Comment on lines
+9
to
+10
|
|
||
| jq -r '.[] | "\(.name) \(.scores[-1])"' scores.json |
Author
There was a problem hiding this comment.
Yes, one simpler option is jq -r '.[] | .name + " " + (.scores[-1] | tostring)' scores.json
nedssoft
added
Complete
Author
|
Thank you, @nedssoft, for the code review. |
- script-05.sh: Replace string interpolation with + operator for name and city - script-06.sh: Use string concatenation and tostring for name and first score - script-07.sh: Use string concatenation and tostring for name and last score - All scripts maintain the same output format
Member
|
Closing PR because the SDC run has finished. Feel free to re-open if you're still working on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
This pull request adds a series of Bash scripts that use
jqto extract and process data from person.json and scores.json. Each script addresses a specific requirement, such as extracting names, formatting addresses, listing player stats, and calculating score totals.Questions
Hi, could you please review my PR? I would really appreciate your feedback.