London | 26-SDC-Mar | Khilola Rustamova| Sprint 4 |Implement cowsay#503
Closed
HilolaRustam wants to merge 9 commits into
Closed
London | 26-SDC-Mar | Khilola Rustamova| Sprint 4 |Implement cowsay#503HilolaRustam wants to merge 9 commits into
HilolaRustam wants to merge 9 commits into
Conversation
HilolaRustam
added
📅 Sprint 4
LonMcGregor
reviewed
Jun 3, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
Contributor
There was a problem hiding this comment.
Part of your implementation may be missing, can you check?
LonMcGregor
added
Reviewed
HilolaRustam
added
Needs Review
LonMcGregor
reviewed
Jun 10, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
Contributor
There was a problem hiding this comment.
Almost there! Good work
|
|
||
| animal = args.animal or "cow" | ||
|
|
||
| print(getattr(cowsay, animal)(message)) |
Contributor
There was a problem hiding this comment.
Do you need this print() here?
Author
There was a problem hiding this comment.
Yes, cowsay returns a string rather than printing directly, so print() is needed. I’ll refactor it slightly for readability by separating the function call from the print statement.
LonMcGregor
added
Reviewed
HilolaRustam
added
Needs Review
LonMcGregor
reviewed
Jun 16, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
Contributor
There was a problem hiding this comment.
Great,there's just one thing left. When you run this, do you see the final line says "None"? Why does it print this?
LonMcGregor
added
Reviewed
HilolaRustam
added
the
Needs Review
LonMcGregor
reviewed
Jun 16, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
Contributor
There was a problem hiding this comment.
Great! the function prints the output by itself.
LonMcGregor
added
Complete
Member
|
Closing PR because the SDC run has finished. Feel free to re-open if you're still working on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Implement cowsay exercise is completed.
Questions