Promote deep-import exports to public API (GMT-1740, rebased onto beta) - #3415
Closed
dreamwasp wants to merge 55 commits into
Closed
Promote deep-import exports to public API (GMT-1740, rebased onto beta)#3415dreamwasp wants to merge 55 commits into
dreamwasp wants to merge 55 commits into
Conversation
Made-with: Cursor # Conflicts: # .eslintrc.js # package.json # yarn.lock
fixed linting errors re: connectedForm
|
View your CI Pipeline Execution ↗ for commit a0c558e ☁️ Nx Cloud last updated this comment at |
|
View your CI Pipeline Execution ↗ for commit 429c2e0 ☁️ Nx Cloud last updated this comment at |
|
Resolved merge conflicts in: - ESLint rule files: removed 'recommended: false' from docs (main's version) - ButtonBase: kept documentation comment - Card styles: switched to useCardElevation hook - MenuItem: using MenuListButton and MenuListItem component names
This reverts commit 429c2e0.
Collaborator
|
📬 Published Alpha Packages:
|
Contributor
|
🚀 Styleguide deploy preview ready! Preview URL: https://6a8d9dde2bdaf2d2afe66c3b--gamut-preview.netlify.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Merges React 19 compatibility work from
cass-gmt-1473-betaontocass-gmt-1740-on-1473-beta. Includes TypeScript type annotation improvements for GridForm and a version plan reflecting React 18.3+ peer support.Breaking API changes (Menu/elements renames and IconOption→IconOptionComponent) have been moved to a separate ticket for independent review.
Changes
TypeScript / Type Safety
GridForm/types.ts— consolidates imports from../Formto useForm/typesexports directly forCheckboxPaddingProps, improving type hygieneVersioning
.nx/version-plans/— adds version plan for React 18.3 + 19 compatibility across core Gamut packagesPR Checklist
Testing Instructions
tsc --noEmitonpackages/gamutto verify type checks passyarn jest packages/gamut/src/GridFormto confirm GridForm tests pass with the import restructure.nx/version-plans/version-plan-1775236316343.md