Remove dead code and over-engineering from test app

Author: TavoNiievez

tests/_app/Controller/AppController.php

@@ -20,7 +20,6 @@
 use Symfony\Component\Validator\Constraints\Email as EmailConstraint;
 use Symfony\Component\Validator\Constraints\NotBlank;
 use Symfony\Contracts\HttpClient\HttpClientInterface;
-use Symfony\Contracts\Translation\TranslatorInterface;
 use Tests\App\Event\TestEvent;
 use Tests\App\Mailer\RegistrationMailer;
 use Twig\Environment;
@@ -130,11 +129,6 @@ public function redirectToHome(): RedirectResponse
         return new RedirectResponse('/');
     }
 
-    public function redirectToSample(): RedirectResponse
-    {
-        return new RedirectResponse('/sample');
-    }
-
     public function register(Request $request, Environment $twig): Response
     {
         if ($request->isMethod('POST')) {
@@ -169,14 +163,9 @@ public function responseWithCookie(): Response
         return $response;
     }
 
-    public function sample(Request $request, Environment $twig): Response
+    public function sample(Environment $twig): Response
     {
-        $request->attributes->set('foo', 'bar');
-
-        $response = new Response($twig->render('sample.html.twig'), 200, ['X-Test' => '1']);
-        $response->headers->setCookie(new Cookie('response_cookie', 'yum'));
-
-        return $response;
+        return new Response($twig->render('sample.html.twig'));
     }
 
     public function sendEmail(RegistrationMailer $mailer): Response
@@ -191,18 +180,6 @@ public function testPage(Environment $twig): Response
         return new Response($twig->render('test_page.html.twig'));
     }
 
-    public function translation(TranslatorInterface $translator): Response
-    {
-        $translator->trans('defined_message');
-
-        return new Response('Translation');
-    }
-
-    public function twig(Environment $twig): Response
-    {
-        return new Response($twig->render('home.html.twig'));
-    }
-
     public function unprocessableEntity(): JsonResponse
     {
         return new JsonResponse([

tests/_app/Repository/UserRepository.php

@@ -10,13 +10,6 @@
 /** @extends EntityRepository<User> */
 final class UserRepository extends EntityRepository implements UserRepositoryInterface
 {
-    public function save(User $user): void
-    {
-        $this->_em->persist($user);
-        $this->_em->flush();
-        $this->_em->clear();
-    }
-
     public function getByEmail(string $email): ?User
     {
         return $this->findOneBy(['email' => $email]);

tests/_app/Repository/UserRepositoryInterface.php

@@ -8,7 +8,5 @@
 
 interface UserRepositoryInterface
 {
-    public function save(User $user): void;
-
     public function getByEmail(string $email): ?User;
 }

tests/_app/config/routes.php

@@ -17,15 +17,12 @@
     $routes->add('http_client', '/http-client')->controller(AppController::class . '::httpClientRequests');
     $routes->add('index', '/')->controller(AppController::class . '::index');
     $routes->add('logout', '/logout')->controller(AppController::class . '::logout');
-    $routes->add('redirect', '/redirect')->controller(AppController::class . '::redirectToSample');
     $routes->add('redirect_home', '/redirect_home')->controller(AppController::class . '::redirectToHome');
     $routes->add('request_attr', '/request_attr')->controller(AppController::class . '::requestWithAttribute');
     $routes->add('response_cookie', '/response_cookie')->controller(AppController::class . '::responseWithCookie');
     $routes->add('response_json', '/response_json')->controller(AppController::class . '::responseJsonFormat');
     $routes->add('sample', '/sample')->controller(AppController::class . '::sample');
     $routes->add('send_email', '/send-email')->controller(AppController::class . '::sendEmail');
     $routes->add('test_page', '/test_page')->controller(AppController::class . '::testPage');
-    $routes->add('translation', '/translation')->controller(AppController::class . '::translation');
-    $routes->add('twig', '/twig')->controller(AppController::class . '::twig');
     $routes->add('unprocessable_entity', '/unprocessable_entity')->controller(AppController::class . '::unprocessableEntity');
 };

tests/_app/config/services.php

@@ -13,7 +13,6 @@
 use Symfony\Component\HttpClient\MockHttpClient;
 use Symfony\Component\HttpClient\TraceableHttpClient;
 use Symfony\Component\HttpKernel\DataCollector\LoggerDataCollector;
-use Symfony\Component\HttpKernel\Kernel as BaseKernel;
 use Symfony\Component\Mailer\EventListener\MessageLoggerListener;
 use Symfony\Component\Notifier\EventListener\NotificationLoggerListener;
 use Tests\App\Command\TestCommand;
@@ -57,7 +56,6 @@
         ->tag('security.user_provider');
 
     $services->alias('security.password_hasher', 'security.user_password_hasher')->public();
-    $services->alias(UserPasswordHasherInterface::class, 'security.user_password_hasher')->public();
 
     if (class_exists(Security::class)) {
         $services->set(Security::class)->arg('$container', service('test.service_container'));
@@ -106,9 +104,4 @@
         ->tag('data_collector', ['id' => 'logger', 'template' => '@WebProfiler/Collector/logger.html.twig', 'priority' => 300]);
     $services->alias('data_collector.logger', LoggerDataCollector::class)->public();
 
-    if (BaseKernel::VERSION_ID < 60100) {
-        $services->defaults()
-            ->bind(\Symfony\Contracts\HttpClient\HttpClientInterface::class . ' $httpClient', service('app.http_client'))
-            ->bind(\Symfony\Contracts\HttpClient\HttpClientInterface::class . ' $jsonClient', service('app.http_client.json_client'));
-    }
 };