Repository navigation
Signature node, hold trigger, full-screen dialogs, more bindable properties - #44
Open
BuildCodelessly wants to merge 11 commits into
Open
BuildCodelessly wants to merge 11 commits into
BuildCodelessly wants to merge 11 commits into
Conversation
Its constructor didn't take positioningMode, aspectRatioLock or reactions, so the generated fromJson cast them as required and a spacer written without them (as other nodes allow) failed to parse. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0147gqWiq3xoEdAGwWSpq9JK
IconNode lists iconColor (already read by the runtime) and iconName among its property variables, so the editor can bind them and conditions and actions can set them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0147gqWiq3xoEdAGwWSpq9JK
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0147gqWiq3xoEdAGwWSpq9JK
DialogPresentation picks a dialog, a bottom sheet, a sheet on mobile and a dialog elsewhere, or a full-screen page. Older actions read as dialogs and leave the field out of their JSON. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0147gqWiq3xoEdAGwWSpq9JK
SignatureNode stores strokes as normalized [x, y] points so a signature replays at any size. TriggerType.hold fires after its duration; rows and columns now declare the triggers they run. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0147gqWiq3xoEdAGwWSpq9JK
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0147gqWiq3xoEdAGwWSpq9JK
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0147gqWiq3xoEdAGwWSpq9JK
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0147gqWiq3xoEdAGwWSpq9JK
CI regenerates *.g.dart and fails on a diff: the generator writes RowColumnNode's reactions first. dialog_presentation_test.dart wasn't formatted. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0147gqWiq3xoEdAGwWSpq9JK
Master landed RowColumnNode spacing, wrap and runSpacing in RowColumnMixin, the same JSON fields this branch added on the node. Keep master's, so a row's spacing applies whether or not it wraps; this branch keeps only the click, long-press and hold triggers rows offer. Regenerated JSON code and formatted master's wrap test for CI. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0147gqWiq3xoEdAGwWSpq9JK
Master landed ShowDialogAction.presentation (dialog, bottom sheet, adaptive) with an alignment for where a dialog opens. Keep master's action and add the full screen presentation this branch had. Both branches added test/minimal_node_json_test.dart; this branch's moves to test/minimal_node_types_json_test.dart. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0147gqWiq3xoEdAGwWSpq9JK
BuildCodelessly
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
API changes found while rebuilding a jobsite daily log app in the editor. Each one fixed something the editor couldn't express. This branch is merged with master; master's row/column spacing and wrap (#40) and dialog presentation and alignment (#41) replace this branch's versions.
SignatureNode(signature): a box to sign in. Itsvalueis a list of strokes;inkColor,strokeWidthandreadOnlyare inSignatureProperties.TriggerType.holdwithTriggerModel.duration(1200 ms by default) for hold-to-confirm. Frames, rectangles, rows and columns offer it. Rows and columns also declare the click and long-press triggers they already ran.DialogPresentation.fullScreen: a show dialog action can cover the whole screen.strokeWeight,flexon every node, andIconNode'siconColorandiconName.destinationId.SpacerNodeJSON no longer requires its base fields.test/minimal_node_types_json_test.dart.Everything is under
## UnreleasedinCHANGELOG.md. Version bumps are left to the release commit.Checks run locally on the head commit, the same steps as CI:
build_runner: no.g.dartdiff.dart format, anddart analyze --fatal-infoswith no issues.dart test: 344 tests passing.dart pub publish --dry-run: 0 warnings.The merge also formats master's
test/row_column_wrap_test.dartand commits its regeneratedexpansion_tile_node.g.dart, which master's own CI flags.Merge order
codelessly_apirelease.🤖 Generated with Claude Code
https://claude.ai/code/session_0147gqWiq3xoEdAGwWSpq9JK