Skip to content

Expand RequestContext.isAjax() to recognize Fetch Metadata requests #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lmajano merged 1 commit into from
Jun 5, 2026
+51 −1
Merged

Expand RequestContext.isAjax() to recognize Fetch Metadata requests #662

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion system/web/context/RequestContext.cfc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1926,7 +1926,18 @@ component serializable="false" accessors="true" {
* Determines if in an Ajax call or not by looking at the request headers
*/
boolean function isAjax(){
return ( getHTTPHeader( "X-Requested-With", "" ) eq "XMLHttpRequest" );
var xRequestedWith = getHTTPHeader( "X-Requested-With", "" );
var fetchMode = getHTTPHeader( "Sec-Fetch-Mode", "" );
var fetchDest = getHTTPHeader( "Sec-Fetch-Dest", "" );

return (
xRequestedWith eq "XMLHttpRequest" ||
(
len( fetchMode ) &&
fetchMode neq "navigate" &&
fetchDest eq "empty"
)
);
}

/***********************************************************************************************************/
Expand Down
39 changes: 39 additions & 0 deletions tests/specs/web/context/RequestContextTest.cfc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -616,6 +616,45 @@ component extends="coldbox.system.testing.BaseModelTest" {
assertTrue( isSimpleValue( test ) );
}

function testIsAjaxWithXMLHttpRequestHeader(){
var event = getRequestContext()
.$( "getHTTPHeader" )
.$args( "X-Requested-With", "" )
.$results( "XMLHttpRequest" );

expect( event.isAjax() ).toBeTrue();
}

function testIsAjaxWithFetchMetadataHeaders(){
var event = getRequestContext()
.$( "getHTTPHeader" )
.$args( "X-Requested-With", "" )
.$results( "" )
.$( "getHTTPHeader" )
.$args( "Sec-Fetch-Mode", "" )
.$results( "cors" )
.$( "getHTTPHeader" )
.$args( "Sec-Fetch-Dest", "" )
.$results( "empty" );

expect( event.isAjax() ).toBeTrue();
}

function testIsAjaxFalseForNavigationRequests(){
var event = getRequestContext()
.$( "getHTTPHeader" )
.$args( "X-Requested-With", "" )
.$results( "" )
.$( "getHTTPHeader" )
.$args( "Sec-Fetch-Mode", "" )
.$results( "navigate" )
.$( "getHTTPHeader" )
.$args( "Sec-Fetch-Dest", "" )
.$results( "document" );

expect( event.isAjax() ).toBeFalse();
}

function testNoLayout(){
var event = getRequestContext();

Expand Down
Loading