fix: ms exact mass (M+)#298
Open
Nicolass67 wants to merge 3 commits intomasterfrom
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the MS info panel to display the charged-species exact mass (M+) rather than the neutral exact mass, aligning the UI with typical MS reporting by subtracting the electron mass, and adds a focused unit test to validate the conversion.
Changes:
- Add MS-specific exact mass formatting that converts neutral mass
MtoM+by subtracting electron mass and formatting to 6 decimals. - Update the InfoPanel label to
Exact mass (M+)and display the converted value. - Add a unit test asserting the displayed M+ value for MS layout.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/components/panel/info.js |
Introduces M→M+ conversion for MS layout and updates the displayed label/value in the InfoPanel. |
src/__tests__/units/components/panel/info.test.js |
Adds a unit test verifying the M+ exact mass display for MS layout. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Exact mass (M+)instead of neutralMin the MS info panelTest plan
Exact mass (M+)