Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4028 +/- ##
=======================================
Coverage 98.30% 98.30%
=======================================
Files 45 45
Lines 1943 1944 +1
Branches 732 733 +1
=======================================
+ Hits 1910 1911 +1
Misses 33 33 🚀 New features to boost your workflow:
|
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
An empty `include` pattern made the coverage provider throw "Expected pattern to be a non-empty string". Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
amanmahajan7
left a comment
There was a problem hiding this comment.
This is great. Anything noteworthy?
| - dependency-name: 'vitest' | ||
| - dependency-name: '@vitest/*' |
There was a problem hiding this comment.
Do we still install these packages separately?
There was a problem hiding this comment.
vite-plus manages these dependencies via vp migrate, as vite-plus expects specific package versions.
I hope they'll make it simpler in the future, or hope they'll release an updater action.
| "oxc.disableNestedConfig": true, | ||
| "oxc.fmt.disableNestedConfig": true |
There was a problem hiding this comment.
It was added by vp migrate
vp does not support nested configs
| "allowScripts": { | ||
| "core-js": false |
There was a problem hiding this comment.
Disables core-js's install script (a donation plea), otherwise npm logs this:
npm warn install-scripts 1 package had install scripts blocked because they are not covered by allowScripts:
npm warn install-scripts core-js@3.50.0 (postinstall: node -e "try{require('./postinstall')}catch(e){}")
npm warn install-scripts
npm warn install-scripts Run `npm install-scripts ls` to review, or `npm install-scripts approve <pkg>` to allow.
https://github.blog/changelog/2026-06-09-upcoming-breaking-changes-for-npm-v12/
| staged: { | ||
| '*': 'vp fmt --no-error-on-unmatched-pattern', | ||
| '*.md': 'vp run eslint' | ||
| }, |
There was a problem hiding this comment.
how do you like the pre commit hooks?
There was a problem hiding this comment.
Works great, essentially invisible since vp fmt is fast, and we rarely touch .md files.
Might have some conflicts if you have staged/unstaged blocks in the same file, but it stashes these unstaged changes while running the hooks.
Though it can lead to git conflicts, and fail to commit, but that's rare.
We could also use *': vp check --fixinstead ofvp fmt`, but that might be a bit too much?
I wonder if we should add more hooks.
| "lint:md": "eslint --max-warnings 0", | ||
| "lint:fix": "oxlint --fix && eslint --fix", | ||
| "typecheck": "tsc --build" | ||
| "prepare": "vp config" |
There was a problem hiding this comment.
only one command needed? nice!
There was a problem hiding this comment.
Well they're moved to tasks in vite.config.ts, so we can benefit from caching.
prepare runs after you run npm install/vp install.
I've added vp run ci (or vpr ci) so you can all the checks locally, just like in CI.
I'm sure there's even more stuff, but that's a good start 🙂 |
https://viteplus.dev/