Conversation
Pressing ArrowLeft on a collapsed child group made the parent group row active without moving focus to it, leaving focus on the child row. Also fix two comments that described the select/unselect branches the wrong way round. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4202 +/- ##
=======================================
Coverage 98.30% 98.30%
=======================================
Files 45 45
Lines 1943 1943
Branches 732 732
=======================================
Hits 1910 1910
Misses 33 33
🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pressing ArrowLeft on a collapsed child group row makes its parent group row active, but focus stays on the child row. Other keyboard navigation in
DataGridand clicking a group row both pass{ shouldFocus: true }, so this path now does too.The existing "cell navigation in a treegrid" test already says the parent group should be focused, but it only checked the active class. It now also asserts
toHaveFocus(); that assertion fails without the fix.Also fixes two comments in the row selection handler that described the select and unselect branches the wrong way round.
Verified locally:
typecheck,lint,format:check,lint:md, andnpm test(529 passed).🤖 Generated with Claude Code