fix: make lint pass on Biome 2.x - #1
Open
sstreichan wants to merge 1 commit into
Open
sstreichan wants to merge 1 commit into
sstreichan wants to merge 1 commit into
Conversation
The config used the Biome 1.x `linter.preset` key, which Biome 2.5 rejects as unknown, so `pnpm lint` (and CI) failed at config parse. Recommended rules are on by default in Biome 2.x, so the key is simply removed. Also apply the project's own format/import order to the files that had drifted, so `biome check` is clean. Co-authored-by: CommandCodeBot <noreply@commandcode.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was kaputt war
pnpm lint(und damit CI) scheiterte schon am Config-Parsen:biome.jsonnutzte den Biome-1.x-Keylinter.preset, den Biome 2.5.14 (die Version im Lockfile) als unknown verwirft.Fix
biome.json:presetentfernt — in Biome 2.x sind die recommended Rules per Default aktiv, undrules.recommendedist in 2.5 deprecated.biome check --write .über die 5 Dateien angewendet, die nicht zum eigenen Style passten (Import-Reihenfolge, 80-Zeilen-Linie).Checks
pnpm lint— clean, keine Warnungenpnpm typecheck— okpnpm test— 24/24 grünAssignee: Autor selbst · Reviewer: CheckMate-Bot