Fix/gitea http client settings - #734
Merged
Merged
Conversation
Credit chrisbelford01 for the HTTP-client wiring fixes published in chrisbelford01/pipeleek. The source commits recorded a placeholder author identity (standard <standard@example.com>); this port uses the repository owner’s GitHub identity with maintainer approval. Adapt the fixes to current code, add regression and CLI coverage, and document shared settings. Preserve emojis, existing features, and defaults. Original source commits: chrisbelford01/pipeleek@2ea6263 chrisbelford01/pipeleek@41b72b0 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Inject the shared HTTP client into the remaining Gitea SDK clients. Add proxy, TLS, timeout, and CLI regression coverage and update proxy documentation. Preserve existing features, defaults, and output. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The narrow client-injection changes follow the established pattern, include focused regression coverage, and have no identified blocking issues.
Review effort: Balanced
Findings: None
What changed in this PR
Makes Gitea helper commands honor Pipeleek’s shared proxy, TLS verification, and HTTP timeout settings.
Changes:
- Injects the shared HTTP client into enumeration, secrets, variables, and vulnerability checks.
- Adds HTTP-settings regression tests and end-to-end proxy coverage.
- Documents shared settings across Gitea commands.
| File | Description |
|---|---|
| tests/e2e/gitea/vuln/vuln_test.go | Tests proxy routing for Gitea and NIST requests. |
| tests/e2e/gitea/variables/variables_test.go | Adds explicit-proxy coverage. |
| tests/e2e/gitea/secrets/secrets_test.go | Tests direct and proxied execution. |
| tests/e2e/gitea/enum/enum_test.go | Tests direct and proxied enumeration. |
| pkg/gitea/vuln/vuln.go | Uses the shared HTTP client. |
| pkg/gitea/variables/variables.go | Uses the shared HTTP client. |
| pkg/gitea/secrets/secrets.go | Uses the shared HTTP client. |
| pkg/gitea/http_settings_test.go | Tests proxy precedence, TLS verification, and timeouts. |
| pkg/gitea/enum/enum.go | Uses the shared HTTP client. |
| docs/introduction/proxying.md | Clarifies Gitea HTTP-settings support. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.