Skip to content

CMP-4436: Add manual rule kubevirt-restrict-exec-access-to-pods (CIS-OCP-Virt 1.11) - #14936

Merged
yuumasato merged 2 commits into
ComplianceAsCode:masterfrom
taimurhafeez:CMP-4436-Add-Manual-rule-restrict-exec-access-to-pods-CIS-OCP-Virt-1.11
Aug 10, 2026
Merged

CMP-4436: Add manual rule kubevirt-restrict-exec-access-to-pods (CIS-OCP-Virt 1.11)#14936
yuumasato merged 2 commits into
ComplianceAsCode:masterfrom
taimurhafeez:CMP-4436-Add-Manual-rule-restrict-exec-access-to-pods-CIS-OCP-Virt-1.11

Conversation

@taimurhafeez

Copy link
Copy Markdown
Contributor

Add a manual rule for CIS OCP-Virt control 1.11 "Restrict exec access to pods". The rule documents the audit procedure (oc adm policy who-can exec pod) and is added to the cis-vm-extension CEL profile. Also relax build_cel_content.py to warn instead of error when a CEL profile references rules without CEL checks, allowing manual rules in CEL profiles. Update CEL documentation accordingly.

Co-Authored-By: Claude

@openshift-ci

openshift-ci Bot commented Jul 27, 2026

Copy link
Copy Markdown

Hi @taimurhafeez. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci Bot added the needs-ok-to-test Used by openshift-ci bot. label Jul 27, 2026
@jan-cerny jan-cerny added the OpenShift OpenShift product related. label Jul 28, 2026
@Vincent056

Copy link
Copy Markdown
Contributor

LGTM on the rule content. Two asks: (1) rebase to drop the duplicated build-script/docs change once #14920 merges; (2) exec is a pod subresource — consider oc adm policy who-can create pods/exec and please verify the current command gives useful output on 4.2x.

@openshift-ci openshift-ci Bot added the needs-rebase Used by openshift-ci bot. label Aug 5, 2026
rhmdnd
rhmdnd previously requested changes Aug 5, 2026

@rhmdnd rhmdnd left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good but we'll need to rebase and add something to the description that clearly points users to CustomRules as a way to automate this.

Thanks @taimurhafeez!

@rhmdnd rhmdnd added the CIS CIS Benchmark related. label Aug 5, 2026
@taimurhafeez
taimurhafeez force-pushed the CMP-4436-Add-Manual-rule-restrict-exec-access-to-pods-CIS-OCP-Virt-1.11 branch from bc612b4 to 966e91d Compare August 6, 2026 10:50
@openshift-ci openshift-ci Bot added needs-rebase Used by openshift-ci bot. and removed needs-rebase Used by openshift-ci bot. labels Aug 6, 2026
…ints organizations to CustomRules for automation.

Co-Authored-By: Claude Opus 4.6 (1M context)
@taimurhafeez
taimurhafeez force-pushed the CMP-4436-Add-Manual-rule-restrict-exec-access-to-pods-CIS-OCP-Virt-1.11 branch from 966e91d to 6c2bc20 Compare August 10, 2026 09:06
@openshift-ci openshift-ci Bot removed the needs-rebase Used by openshift-ci bot. label Aug 10, 2026
@yuumasato

Copy link
Copy Markdown
Member

/ok-to-test

@openshift-ci openshift-ci Bot added ok-to-test Used by openshift-ci bot. and removed needs-ok-to-test Used by openshift-ci bot. labels Aug 10, 2026

@yuumasato yuumasato left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@yuumasato yuumasato added this to the 0.1.82 milestone Aug 10, 2026
@yuumasato
yuumasato dismissed rhmdnd’s stale review August 10, 2026 14:55

Lance's review has been addressed.

@yuumasato
yuumasato merged commit b137999 into ComplianceAsCode:master Aug 10, 2026
69 of 73 checks passed
@yuumasato yuumasato self-assigned this Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CIS CIS Benchmark related. ok-to-test Used by openshift-ci bot. OpenShift OpenShift product related.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants