CMP-4437: Add manual rule kubevirt-restrict-vnc-access-to-workloads(CIS OCP-Virt 1.12)) - #14937
Conversation
|
Hi @taimurhafeez. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
LGTM — the jq rolebinding audit for |
rhmdnd
left a comment
There was a problem hiding this comment.
We're on the right track, just needs a rebase and an update in the description text that points users to CustomRules as a way to automate this finding.
d41dcc5 to
00f1ae3
Compare
00f1ae3 to
0983f54
Compare
…CIS OCP-Virt 1.12)
explains manual status and points organizations to CustomRules for automation. Co-Authored-By: Claude Opus 4.6
0983f54 to
aed9a6b
Compare
|
@taimurhafeez: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
Add a manual rule for CIS OCP-Virt control 1.12 "Restrict VNC access to cluster workloads". The rule documents the audit procedure for reviewing rolebindings that grant the token.kubevirt.io:generate role, and is added to the cis-vm-extension CEL profile. Also relax build_cel_content.py to warn instead of error when a CEL profile references rules without CEL checks, allowing manual rules in CEL profiles. Update CEL documentation accordingly.
Co-Authored-By: Claude