Skip to content

CMP-4446: Add manual rule kubevirt-disable-intel-txt (CIS OCP-Virt 5.1) - #14941

Merged
Vincent056 merged 1 commit into
ComplianceAsCode:masterfrom
taimurhafeez:CMP-4446-Add-manual-rule-disable-Intel-TXT(CIS-OCP-Virt-5.1)
Aug 12, 2026
Merged

CMP-4446: Add manual rule kubevirt-disable-intel-txt (CIS OCP-Virt 5.1)#14941
Vincent056 merged 1 commit into
ComplianceAsCode:masterfrom
taimurhafeez:CMP-4446-Add-manual-rule-disable-Intel-TXT(CIS-OCP-Virt-5.1)

Conversation

@taimurhafeez

Copy link
Copy Markdown
Contributor

Add a manual rule for CIS OCP-Virt control 5.1 "Disable Intel Trusted Execution Technology (TXT)". The rule documents the host firmware audit procedure (fwupdmgr get-bios-settings) and is added to the cis-vm-extension CEL profile. Also relax build_cel_content.py to warn instead of error when a CEL profile references rules without CEL checks, allowing manual rules in CEL profiles. Update CEL documentation accordingly.

Co-Authored-By: Claude

@openshift-ci openshift-ci Bot added the needs-ok-to-test Used by openshift-ci bot. label Jul 27, 2026
@openshift-ci

openshift-ci Bot commented Jul 27, 2026

Copy link
Copy Markdown

Hi @taimurhafeez. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jan-cerny jan-cerny added the OpenShift OpenShift product related. label Jul 28, 2026
@Vincent056

Copy link
Copy Markdown
Contributor

LGTM — correct direction (benchmark wants TXT disabled) and fwupdmgr matches the suggested audit. Two asks: (1) rebase to drop the duplicated build-script/docs change once #14920 merges; (2) note in the description that firmware tooling varies by vendor and BIOS access may be required.

@openshift-ci openshift-ci Bot added the needs-rebase Used by openshift-ci bot. label Aug 5, 2026

@rhmdnd rhmdnd left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a legitimate use case for Manual unless we can access fwupdmgr as a node check (I'm not seeing any other rules that do this today)?

Otherwise we'll just need a rebase.

@rhmdnd rhmdnd added the CIS CIS Benchmark related. label Aug 5, 2026
@taimurhafeez
taimurhafeez force-pushed the CMP-4446-Add-manual-rule-disable-Intel-TXT(CIS-OCP-Virt-5.1) branch from 6c85d90 to bb0e841 Compare August 6, 2026 11:28
@openshift-ci openshift-ci Bot added needs-rebase Used by openshift-ci bot. and removed needs-rebase Used by openshift-ci bot. labels Aug 6, 2026
@taimurhafeez
taimurhafeez force-pushed the CMP-4446-Add-manual-rule-disable-Intel-TXT(CIS-OCP-Virt-5.1) branch from bb0e841 to c080bbd Compare August 10, 2026 09:08
@openshift-ci openshift-ci Bot removed the needs-rebase Used by openshift-ci bot. label Aug 10, 2026
@taimurhafeez
taimurhafeez force-pushed the CMP-4446-Add-manual-rule-disable-Intel-TXT(CIS-OCP-Virt-5.1) branch from c080bbd to c70dec1 Compare August 10, 2026 15:05

@Vincent056 Vincent056 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@Vincent056

Copy link
Copy Markdown
Contributor

/ok-to-test

@openshift-ci openshift-ci Bot added ok-to-test Used by openshift-ci bot. and removed needs-ok-to-test Used by openshift-ci bot. labels Aug 12, 2026
@openshift-ci

openshift-ci Bot commented Aug 12, 2026

Copy link
Copy Markdown

@taimurhafeez: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-openshift-node-compliance c70dec1 link false /test e2e-aws-openshift-node-compliance

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@yuumasato yuumasato added this to the 0.1.82 milestone Aug 12, 2026
@Vincent056
Vincent056 merged commit d8c9187 into ComplianceAsCode:master Aug 12, 2026
69 of 74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CIS CIS Benchmark related. ok-to-test Used by openshift-ci bot. OpenShift OpenShift product related.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants