Skip to content

Remove hmac-ripemd160 from RHEL OpenSCAP SSH MAC value selectors - #15070

Merged
jan-cerny merged 1 commit into
ComplianceAsCode:masterfrom
phatkamk-lang:remove-hmac-ripemd160-rhel-macs
Sep 1, 2026
Merged

Remove hmac-ripemd160 from RHEL OpenSCAP SSH MAC value selectors#15070
jan-cerny merged 1 commit into
ComplianceAsCode:masterfrom
phatkamk-lang:remove-hmac-ripemd160-rhel-macs

Conversation

@phatkamk-lang

@phatkamk-lang phatkamk-lang commented Aug 27, 2026

Copy link
Copy Markdown

Description:

  • Remove hmac-ripemd160 from the sshd_strong_macs default allow-list.
  • Remove hmac-ripemd160 and hmac-ripemd160-etm@openssh.com from
    cis_rhel8, cis_rhel9, and cis_rhel10 deny-lists.

Rationale:

Review Hints:

  • One file: linux_os/guide/services/ssh/sshd_strong_macs.var
  • On RHEL 8: sshd -t succeeds with the new default and new cis_rhel8 list
  • The generated remediation for the RHEL profiles should not contain
    hmac-ripemd160 in the affected selectors.

…for OpenSCAP remediation

hmac-ripemd160 is not supported by the affected RHEL OpenSSH

implementation. The default selector is an allow-list, so remediation

writes the unsupported MAC into sshd_config and sshd fails with

"Bad SSH2 mac spec". Remove the algorithm from the default selector

and from the cis_rhel8/9/10 deny-lists.
@openshift-ci openshift-ci Bot added the needs-ok-to-test Used by openshift-ci bot. label Aug 27, 2026
@openshift-ci

openshift-ci Bot commented Aug 27, 2026

Copy link
Copy Markdown

Hi @phatkamk-lang. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@phatkamk-lang

Copy link
Copy Markdown
Author

This is a RHEL-only change to sshd_strong_macs (default + cis_rhel8/9/10).
#14447 was SLE-only. Could a Red Hat reviewer take a look?
@ComplianceAsCode/red-hatters

@jan-cerny jan-cerny added the bugfix Fixes to reported bugs. label Sep 1, 2026
@jan-cerny jan-cerny added this to the 0.1.83 milestone Sep 1, 2026

@jan-cerny jan-cerny left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. The hmac-ripemd160 MAC was removed from OpenSSH long time ago. https://www.openssh.org/txt/release-7.6 Notice that the rule sshd_use_strong_macs that uses this variable isn’t currently selected in any RHEL profile.

@jan-cerny
jan-cerny merged commit 8cdaa3d into ComplianceAsCode:master Sep 1, 2026
61 of 62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Fixes to reported bugs. needs-ok-to-test Used by openshift-ci bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants