Fix race condition: detect stale ProfileBundle status after CEL content update - #83
Open
taimurhafeez wants to merge 1 commit into
Conversation
|
@taimurhafeez: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After ensureCELContentFile updates spec.celContentFile on the ocp4 ProfileBundle, waitForValidTestProfileBundles could immediately accept the stale VALID status from the initial XCCDF-only parse before the controller had time to re-parse with CEL content. This caused ValidateProfile to fail with "profile not found" for CEL-only profiles.
Track the ProfileBundle's resourceVersion after the spec update and require it to change before accepting VALID status, ensuring the controller has reconciled with the new CEL content file.
Reference PR where it was observed.
CI Job Result
Co-Authored-By: Claude Opus 4.6