Repository navigation
Wrap a connector answer that only looks like an untrusted-data envelope - #834
Open
RaphaelFakhri wants to merge 2 commits into
Open
RaphaelFakhri wants to merge 2 commits into
RaphaelFakhri wants to merge 2 commits into
Conversation
RaphaelFakhri
requested review from
MikeRyanDev,
davidmckayv,
guidovizoso,
mxmzb and
tylerslaton
as code owners
October 25, 2026 07:15
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
markUntrustedreturns content unchanged whenisMarkedUntrustedsays it is already an envelope. That check accepted any text that started withCRITICAL: The following, contained the opening tag, and ended with the closing tag. A connector's answer is outside content, so it could carry a notice in its own words, or close the tag and continue with instructions outside it, and it reached the model with no envelope at all.For example,
markUntrusted(forged, "connector result")returned this string unchanged:isMarkedUntrustednow accepts only whatmarkUntrusteditself produces: the notice for the source the tag names, a source thatmarkUntrustedcould have written (no quotes, angle brackets or line breaks, at most 120 characters), the opening tag, a body with no closing tag, and the closing tag last. Anything else is wrapped as usual. Genuine envelopes, including an empty one, are still recognised, so nothing is wrapped twice.The responsibility trigger path passes
JSON.stringifyoutput, which cannot take this shape, so connector results (vendorAnswer) are the reachable case.Where it runs
withoutUntrustedEnvelopeis unchanged.Boundary and audit
Changelog
CHANGELOG.mdunderUnreleased.Proof
New test
is still applied to content written to look like oneinserver/tests/untrusted-content.test.ts.Before the fix, with
server/src/untrusted-content.tsreverted:After: