Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Timed event drafts currently accept
24:00becauseDate.parsesilently moves it to the following day and the remaining validation only checks the date and offset. Reject that clock time before preparing a calendar action, matching the date editor's existing behavior.Use the existing Zod ISO datetime validators with explicit minute precision support. Regression coverage rejects 24:00 in either endpoint with minute/second/fraction precision and multiple offsets; existing tests retain valid leap dates, minute-only input, full timestamps, and all-day events.
Validation: regression failed against main before the fix; domain/actions/Google tests 62/62; full suite 485 passed, 3 platform-dependent skips, 0 failed. Repository lint, server/mobile/worker typechecks, server build and web/iOS/Android exports pass. No live calendar mutation was performed.