Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The advertised 500 KB transaction CSV limit currently counts UTF-16 code units. Chinese, emoji and other multibyte content can therefore exceed the file-size limit while being accepted.
Count UTF-8 bytes before parsing while keeping the existing 500,000-byte threshold and error message. Regression coverage verifies an oversized Chinese import is rejected and that ASCII, Chinese and emoji imports at exactly 500,000 bytes retain their transaction text and amount; one additional byte is rejected.
Validation: both new regressions failed against main before the fix; finance tests 9/9; full suite 486 passed, 3 platform-dependent skips, 0 failed. Repository lint, server/mobile/worker typechecks and server build pass. Independent review found no actionable issues. This changes only the server-side CSV input limit.