Repository navigation
fix(research): support overlap pagination on older gh - #1970
Merged
Merged
Conversation
Normalize legacy --slurp arguments at the paginated CLI boundary and collect compact JSON pages without requiring that flag. Keep REST callers unchanged so the fix composes with the path index. Reject absent or malformed pages before publishing a complete snapshot. Split only LF separators to preserve Unicode text in PR bodies. Add regression controls for legacy arguments, pagination, failed refreshes, cache reuse and unchanged GraphQL behavior.
petalas
force-pushed
the
fix/overlap-gh-pagination
branch
from
October 14, 2026 16:57
a1333b6 to
9c2fdd8
Compare
Contributor
|
Batch review at Merged to Reviewed scope: REST pagination preserves the nested-page contract without gh --slurp, including Unicode line separators, later-page drafts, failed refreshes and cached coverage. Seven regression groups verify failure retains prior complete data. No mathematical claim. The pinned scoped command passed; the batch ledger contains its command, input hashes, environment and log. This incorporates the research/tooling contribution and does not change the selected κ or discharge the inherited multiplication-theorem assumptions. Batch review, attribution and evidence. Thank you for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep complete open-PR pagination on GitHub CLI releases without
--slurp. Normalize the legacy argument insidegh_json, leaving its callers unchanged. This preserves merged PR #1623's path-index fetching and avoids a caller conflict.Reject absent or malformed pages. Preserve the previous complete snapshot when any page fails. Split only LF separators so embedded Unicode line separators survive. Single-response GraphQL behavior and the cache schema are unchanged.
Retain Douglas Colkitt's helper and cache design. Cinna Davis's earlier report identified the unsupported flag. This patch adds the correction and reproducible regression coverage. The sampled
complex-new-helper-inventorytask changed scope to tooling; this supplies no new helper inventory or bound improvement.Evidence
unknown flag: --slurp. After: all seven focused regressions pass in standard and optimized modes.51122344de9382e784c7f89953456d8cd55513ef, including Tooling: search open-PR overlap by changed file path in find_overlap (no new kappa) #1623. All 60 research-workflow tests pass on that combined tree with no skips. All 49 pass on this branch with no skips.2026-10-14T16:53:29Z.python3.12 -X dev -W error -B -m unittest discover -s tests -p 'test_research_*.py' python3.12 -I -O -B tests/test_research_overlap_pagination.py python3.12 -B scripts/research_baseline.pyMerge Danger
Door: two-way
Blast Radius: coordination
Only paginated REST decoding and its tests change. No scientific evidence, selected frontier or cache format changes. Overlap reports remain search leads, not novelty certificates. No full mathematical cold replay or hosted-CI result is claimed.