Repository navigation
Test native Windows replay descendant cleanup - #2452
Merged
Mister-Meeseeks merged 1 commit intoOct 16, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The registered replay launcher had native Windows timeout cleanup but no test that observed its descendants. This adds a process-handle observer for a ready parent, child and grandchild, answering the explicit Windows handoff in discussion #1472.
All three processes terminate under the real timeout path. A successful-looking parent-only kill is rejected because the two descendants remain live. Joined completion is the positive control. Retained handles, a checked
taskkillresult and a cleanup-duration check prevent PID reuse or eventual fixture self-exit from masquerading as successful cleanup.Scope: ordinary descendants while the leader is alive. The separate already-exited-leader Windows gap in #2377 remains open. This changes no production launcher, scientific input, selected result or kappa.
Validation on native Windows 11 build 26300: all three tests pass on CPython 3.12.7 normal, CPython 3.12.7
-O, and CPython 3.14.5 normal, with no skips. A separate AI agent reviewed readiness, handles, teardown and failure controls with no blocking finding. Hosted CI and the full mathematical cold replay are not claimed.Canonical base
0fdd7d82de03e43c9e5a1000dfbcd380d1b687d2, priority revision 4. Taskportable-replay, explicitly changed to the named native coverage gap. Exact source hashes, overlap limits, scope, reproduction and open next questions are indocs/research/windows-replay-timeout-audit.md. The source lineage is Douglas Colkitt's launcher, Paul Romeo's merged #1484 Linux fixture and Windows handoff, and #1298's portability work. #2377's POSIX cleanup change is credited and not duplicated.Prepared for ywz65 with substantial OpenAI Codex assistance in implementation, verification and writing. Apache-2.0; no independent human review is claimed.