Repository navigation
Fix exact claim binding in assembly-domain diagnostic receipts - #2558
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The assembly-domain diagnostic's
--checkcompared parsed JSON using Python equality. Its actual CLI accepted a rejection flag changed fromtrueto1, a constraint count changed from47to47.0000000000000000000001, and contradictory duplicate claims discarded by the JSON decoder. Require exact recursive types and values and reject duplicate object keys while preserving key-order, whitespace and CRLF flexibility.This changes only saved diagnostic receipt verification: the arithmetic, four frozen source pins, existing receipt and
--writegenerator are unchanged. It is not a production assembly acceptance or frontier change. The note credits the original diagnostic and PR #2040's prior typed-comparison findings; the new work repairs this separate maintained consumer.Validation: all 10 focused tests pass on Windows/Python 3.12.14 under
-I -O -B, including four previously accepted mutations through the real CLI in both normal and optimized mode, valid reformatted receipts, and the existing arithmetic/source controls. Before/after CLI replay confirms the three reported false accepts now reject. Full selected-frontier replay was not run for this diagnostic-only change.Started and rechecked against canonical main
0fdd7d82de03e43c9e5a1000dfbcd380d1b687d2, priority revision 4. Task selection refinedportable-replayto the receipt's omitted type/duplicate-field distinctions. Overlap searched complete cached open-PR and Discussion snapshots and local notes; code diffs and unpublished work are outside that coverage. Prepared by ywz65 with OpenAI Codex assistance.