Repository navigation
Fix ordered branch exclusions in the selected replay CI guard - #2928
Merged
Mister-Meeseeks merged 1 commit intoOct 16, 2026
Merged
Mister-Meeseeks merged 1 commit into
Mister-Meeseeks merged 1 commit into
Conversation
6 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The selected-replay CI guard accepted
branches: [main, '!main']and reported complete trigger coverage, although GitHub excludes main. Reuse the guard's existing ordered glob matcher for branch inclusion, preserving its explicit-main restriction and advisory default.Add three regression groups and a scoped evidence note. This follows Sagar Thakrar's guard in #1361 and Discussion #2926. The current workflow passes; no missed hosted run is claimed. No construction, source archive, selected record or kappa changes.
Evidence
-O. Forty related source-binding and replay-bookkeeping tests pass on Python 3.12. The selected-record check and current-tree--require-triggerscheck pass. Ruff E4/E7/E9/F checks pass, with no additional diagnostics under the broader local configuration.Merge Danger
Door: two-way
Blast Radius: tooling
Branch exclusions and unsupported branch globs now produce coverage errors. They fail the command only with
--require-triggers. The production correction is two lines; the mathematical replay and frozen evidence are unchanged.